Skip to content

Commit afa7058

Browse files
committed
Fix two bugs in OPAL_FLAGS_APPEND_MOVE
Fix two issues in OPAL_FLAGS_APPEND_MOVE, which impacted the static library list in the wrapper compilers. First, an assignment was outside the conditional clause, resulting in the original array being wiped out if the input did not contain any -l arguments. Second, we did not have the default case to handle arguments that did not begin with -I, -L, or -l. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
1 parent c16fd23 commit afa7058

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

config/opal_functions.m4

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -515,8 +515,9 @@ AC_DEFUN([OPAL_FLAGS_APPEND_MOVE], [
515515
AS_IF([test "x$val" != "x$arg"],
516516
[OPAL_APPEND([opal_tmp_variable], [$val])])
517517
done
518-
OPAL_APPEND([opal_tmp_variable], [$arg])])
519-
$1="$opal_tmp_variable"
518+
OPAL_APPEND([opal_tmp_variable], [$arg])
519+
$1="$opal_tmp_variable"],
520+
[OPAL_APPEND([$1], [$arg])])
520521
done
521522

522523
OPAL_VAR_SCOPE_POP

0 commit comments

Comments
 (0)