Skip to content

Commit ad9fae9

Browse files
committed
osc/rdma: Fix double assignment typo
Fix an assignment of request onto itself, which was a harmless typo, but was responsible for Coverity issues CID 1429865 and CID 1429864. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
1 parent 5246b66 commit ad9fae9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ompi/mca/osc/rdma/osc_rdma_comm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ static void ompi_osc_rdma_put_complete (struct mca_btl_base_module_t *btl, struc
398398

399399
/* the lowest bit is used as a flag indicating this put operation has a request */
400400
if ((intptr_t) context & 0x1) {
401-
ompi_osc_rdma_request_t *request = request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1);
401+
ompi_osc_rdma_request_t *request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1);
402402
sync = request->sync;
403403

404404
if (0 == OPAL_THREAD_ADD_FETCH32 (&request->outstanding_requests, -1)) {
@@ -429,7 +429,7 @@ static void ompi_osc_rdma_put_complete_flush (struct mca_btl_base_module_t *btl,
429429

430430
/* the lowest bit is used as a flag indicating this put operation has a request */
431431
if ((intptr_t) context & 0x1) {
432-
ompi_osc_rdma_request_t *request = request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1);
432+
ompi_osc_rdma_request_t *request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1);
433433
module = request->module;
434434

435435
if (0 == OPAL_THREAD_ADD_FETCH32 (&request->outstanding_requests, -1)) {

0 commit comments

Comments
 (0)