Skip to content

Commit a81d3cd

Browse files
bwbarrettawlauria
authored andcommitted
Complete removal of ident code
Commit 9f15ca6 removed most, but not all, of the #ident / #pragma ident code in Open MPI. Remove the rest of the code, including the configure checks for #ident / #pragma ident support. This patch fixes a compile error when weak symbols are disabled that was caused by the previous patch only removing some of the ident code in the fortran library. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 6b0038e)
1 parent 60ab729 commit a81d3cd

File tree

4 files changed

+0
-113
lines changed

4 files changed

+0
-113
lines changed

config/opal_check_ident.m4

Lines changed: 0 additions & 101 deletions
This file was deleted.

configure.ac

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -395,10 +395,6 @@ AM_CONDITIONAL(OMPI_NEED_WINDOWS_REPLACEMENTS,
395395
# Do all Interix detections if necessary
396396
OMPI_INTERIX
397397

398-
# Does the compiler support "ident"-like constructs?
399-
400-
OPAL_CHECK_IDENT([CC], [CFLAGS], [c], [C])
401-
402398
#
403399
# Check for some types
404400
#

ompi/mpi/fortran/mpif-h/init_f.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
#include "ompi_config.h"
2424

25-
const char ident[] = OMPI_IDENT_STRING;
26-
2725
#include "ompi/mpi/fortran/mpif-h/bindings.h"
2826

2927
#if OMPI_BUILD_MPI_PROFILING

oshmem/runtime/oshmem_shmem_init.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,6 @@
6565
#include <sys/mman.h>
6666
#endif
6767

68-
#if OPAL_CC_USE_PRAGMA_IDENT
69-
#pragma ident OMPI_IDENT_STRING
70-
#elif OPAL_CC_USE_IDENT
71-
#ident OSHMEM_IDENT_STRING
72-
#endif
73-
7468
/*
7569
* WHAT: add thread for invoking opal_progress() function
7670
* WHY: SHMEM based on current ompi/trunk (by the time of integrating into Open MPI)

0 commit comments

Comments
 (0)