Skip to content

Commit a15e5dc

Browse files
committed
COLL TUNED: remove stray selection of linear algs for alreduce and allgather
These selections seem harmful in my measurements and don't seem to be motivated by previous measurement data. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
1 parent 22e289b commit a15e5dc

File tree

1 file changed

+9
-49
lines changed

1 file changed

+9
-49
lines changed

ompi/mca/coll/tuned/coll_tuned_decision_fixed.c

Lines changed: 9 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -92,30 +92,10 @@ ompi_coll_tuned_allreduce_intra_dec_fixed(const void *sbuf, void *rbuf, int coun
9292
} else {
9393
alg = 2;
9494
}
95-
} else if (communicator_size < 32) {
96-
alg = 3;
97-
} else if (communicator_size < 64) {
98-
if (total_dsize < 131072) {
99-
alg = 1;
100-
} else {
101-
alg = 3;
102-
}
10395
} else if (communicator_size < 128) {
104-
if (total_dsize < 128) {
105-
alg = 1;
106-
} else if (total_dsize < 512) {
107-
alg = 3;
108-
} else if (total_dsize < 8192) {
109-
alg = 1;
110-
} else {
111-
alg = 3;
112-
}
96+
alg = 3;
11397
} else if (communicator_size < 256) {
114-
if (total_dsize < 2048) {
115-
alg = 2;
116-
} else if (total_dsize < 16384) {
117-
alg = 1;
118-
} else if (total_dsize < 131072) {
98+
if (total_dsize < 131072) {
11999
alg = 2;
120100
} else if (total_dsize < 524288) {
121101
alg = 3;
@@ -183,23 +163,13 @@ ompi_coll_tuned_allreduce_intra_dec_fixed(const void *sbuf, void *rbuf, int coun
183163
alg = 6;
184164
}
185165
} else if (communicator_size < 128) {
186-
if (total_dsize < 128) {
187-
alg = 1;
188-
} else if (total_dsize < 512) {
189-
alg = 3;
190-
} else if (total_dsize < 8192) {
191-
alg = 1;
192-
} else if (total_dsize < 262144) {
166+
if (total_dsize < 262144) {
193167
alg = 3;
194168
} else {
195169
alg = 6;
196170
}
197171
} else if (communicator_size < 256) {
198-
if (total_dsize < 2048) {
199-
alg = 2;
200-
} else if (total_dsize < 16384) {
201-
alg = 1;
202-
} else if (total_dsize < 131072) {
172+
if (total_dsize < 131072) {
203173
alg = 2;
204174
} else if (total_dsize < 262144) {
205175
alg = 3;
@@ -1158,19 +1128,15 @@ int ompi_coll_tuned_allgather_intra_dec_fixed(const void *sbuf, int scount,
11581128
alg = 4;
11591129
}
11601130
} else if (communicator_size < 128) {
1161-
if (total_dsize < 64) {
1162-
alg = 1;
1163-
} else if (total_dsize < 512) {
1131+
if (total_dsize < 512) {
11641132
alg = 3;
11651133
} else if (total_dsize < 65536) {
11661134
alg = 5;
11671135
} else {
11681136
alg = 4;
11691137
}
11701138
} else if (communicator_size < 256) {
1171-
if (total_dsize < 32) {
1172-
alg = 1;
1173-
} else if (total_dsize < 512) {
1139+
if (total_dsize < 512) {
11741140
alg = 3;
11751141
} else if (total_dsize < 131072) {
11761142
alg = 5;
@@ -1182,9 +1148,7 @@ int ompi_coll_tuned_allgather_intra_dec_fixed(const void *sbuf, int scount,
11821148
alg = 4;
11831149
}
11841150
} else if (communicator_size < 512) {
1185-
if (total_dsize < 16) {
1186-
alg = 1;
1187-
} else if (total_dsize < 32) {
1151+
if (total_dsize < 32) {
11881152
alg = 3;
11891153
} else if (total_dsize < 128) {
11901154
alg = 2;
@@ -1200,9 +1164,7 @@ int ompi_coll_tuned_allgather_intra_dec_fixed(const void *sbuf, int scount,
12001164
alg = 4;
12011165
}
12021166
} else if (communicator_size < 1024) {
1203-
if (total_dsize < 4) {
1204-
alg = 1;
1205-
} else if (total_dsize < 64) {
1167+
if (total_dsize < 64) {
12061168
alg = 3;
12071169
} else if (total_dsize < 256) {
12081170
alg = 2;
@@ -1212,9 +1174,7 @@ int ompi_coll_tuned_allgather_intra_dec_fixed(const void *sbuf, int scount,
12121174
alg = 5;
12131175
}
12141176
} else if (communicator_size < 2048) {
1215-
if (total_dsize < 2) {
1216-
alg = 1;
1217-
} else if (total_dsize < 4) {
1177+
if (total_dsize < 4) {
12181178
alg = 3;
12191179
} else if (total_dsize < 8) {
12201180
alg = 2;

0 commit comments

Comments
 (0)