Skip to content

Commit 9f39a32

Browse files
committed
Revert "scoll/mpi: Correct allreduce call for in-place buffers"
This was already fixed on the master/v5.0.x branch by #8041: dfe20e0 This reverts commit 1ddcfcc. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
1 parent e449535 commit 9f39a32

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

oshmem/mca/scoll/mpi/scoll_mpi_ops.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,9 @@ int mca_scoll_mpi_reduce(struct oshmem_group_t *group,
256256
SCOLL_DEFAULT_ALG);
257257
return rc;
258258
}
259-
rc = mpi_module->comm->c_coll->coll_allreduce( (sbuf == rbuf ? MPI_IN_PLACE : sbuf) , rbuf, (int)count, dtype, h_op, mpi_module->comm, mpi_module->comm->c_coll->coll_allreduce_module);
259+
rc = mpi_module->comm->c_coll->coll_allreduce(sbuf, rbuf, (int)count, dtype, h_op, mpi_module->comm, mpi_module->comm->c_coll->coll_allreduce_module);
260260
#else
261-
rc = mpi_module->comm->c_coll->coll_allreduce( (sbuf == rbuf ? MPI_IN_PLACE : sbuf), rbuf, count, dtype, h_op, mpi_module->comm, mpi_module->comm->c_coll->coll_allreduce_module);
261+
rc = mpi_module->comm->c_coll->coll_allreduce(sbuf, rbuf, count, dtype, h_op, mpi_module->comm, mpi_module->comm->c_coll->coll_allreduce_module);
262262
#endif
263263
if (OMPI_SUCCESS != rc){
264264
MPI_COLL_VERBOSE(20,"RUNNING FALLBACK REDUCE");

0 commit comments

Comments
 (0)