Skip to content

Commit 9f15ca6

Browse files
committed
Cleanup #ident warnings.
- runtime/opal_init.c:86: warning: #ident is a GCC extension - runtime/ompi_mpi_init.c:123: warning: #ident is a GCC extension - pinit_f.c:29: warning: #ident is a GCC extension '#ident' was added at the request of Sun a long time ago, however it probably is no longer important since modern packaging systems tend to maintain good control of what files are associated with what packages. It could also be used to detect capabilities in certain environments (such as debuggers). That said - it's not clear that anyone is relying on this, so it is probably safe to remove and clean up the warnings. This commit is essentially a revert of: 005652c If anyone wants this funtionality back, it is easy to put back. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
1 parent d4d5ff3 commit 9f15ca6

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

ompi/mpi/fortran/mpif-h/init_f.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,7 @@
2222

2323
#include "ompi_config.h"
2424

25-
#if (OPAL_HAVE_WEAK_SYMBOLS || ! OMPI_BUILD_MPI_PROFILING)
26-
#if OPAL_CC_USE_PRAGMA_IDENT
27-
#pragma ident OMPI_IDENT_STRING
28-
#elif OPAL_CC_USE_IDENT
29-
#ident OMPI_IDENT_STRING
30-
#else
3125
const char ident[] = OMPI_IDENT_STRING;
32-
#endif
33-
#endif
34-
3526

3627
#include "ompi/mpi/fortran/mpif-h/bindings.h"
3728

ompi/runtime/ompi_mpi_init.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ OPAL_DECLSPEC void (*__malloc_initialize_hook) (void) =
117117
*/
118118
#include <float.h>
119119

120-
#if OPAL_CC_USE_PRAGMA_IDENT
121-
#pragma ident OMPI_IDENT_STRING
122-
#elif OPAL_CC_USE_IDENT
123-
#ident OMPI_IDENT_STRING
124-
#endif
125120
const char ompi_version_string[] = OMPI_IDENT_STRING;
126121

127122
/*

opal/runtime/opal_init.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@
8080
#include "opal/util/sys_limits.h"
8181
#include "opal/util/timings.h"
8282

83-
#if OPAL_CC_USE_PRAGMA_IDENT
84-
# pragma ident OPAL_IDENT_STRING
85-
#elif OPAL_CC_USE_IDENT
86-
# ident OPAL_IDENT_STRING
87-
#endif
8883
const char opal_version_string[] = OPAL_IDENT_STRING;
8984

9085
int opal_initialized = 0;

0 commit comments

Comments
 (0)