sharedfp/sm: Fix resource leak

bwbarrett · bwbarrett · commit 9b8950574f86 · 2022-01-25T19:05:32.000Z
Fix resource leak in error handling that was identified by coverity
(CID 1497839 and 1497838).

Signed-off-by: Brian Barrett &lt;bbarrett@amazon.com&gt;
diff --git a/ompi/mca/sharedfp/sm/sharedfp_sm_file_open.c b/ompi/mca/sharedfp/sm/sharedfp_sm_file_open.c
@@ -143,6 +143,11 @@ int mca_sharedfp_sm_file_open (struct ompi_communicator_t *comm,
         memset ( &sm_offset, 0, sizeof (struct mca_sharedfp_sm_offset ));
         err = opal_best_effort_write ( sm_fd, &sm_offset, sizeof(struct mca_sharedfp_sm_offset));
         if (OPAL_SUCCESS != err) {
+            free(filename_basename);
+            free(sm_filename);
+            free(sm_data);
+            free(sh);
+            close (sm_fd);
             return err;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,11 @@ int mca_sharedfp_sm_file_open (struct ompi_communicator_t *comm,`
`143`	`143`	`memset ( &sm_offset, 0, sizeof (struct mca_sharedfp_sm_offset ));`
`144`	`144`	`err = opal_best_effort_write ( sm_fd, &sm_offset, sizeof(struct mca_sharedfp_sm_offset));`
`145`	`145`	`if (OPAL_SUCCESS != err) {`
	`146`	`+ free(filename_basename);`
	`147`	`+ free(sm_filename);`
	`148`	`+ free(sm_data);`
	`149`	`+ free(sh);`
	`150`	`+ close (sm_fd);`
`146`	`151`	`return err;`
`147`	`152`	`}`
`148`	`153`	`}`