Skip to content

Commit 975e3cd

Browse files
committed
mpiext: updates for header file locations
Per discussion on #6030 and #6145, move around where MPI extension header files are installed (specifically: the installation tree path does not need to match the source tree path). For reference, header files were installed like this : - <prefix>/include/openmpi/ompi/mpiext/pcollreq/mpif-h/mpiext_pcollreq_mpifh.h - <prefix>/include/openmpi/ompi/mpiext/pcollreq/c/mpiext_pcollreq_c.h and they are now installed like this : - <prefix>/include/openmpi/mpiext/mpiext_pcollreq_mpifh.h - <prefix>/include/openmpi/mpiext/mpiext_pcollreq_c.h Signed-off-by: Jeff Squyres <jsquyres@cisco.com> Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
1 parent 4918fc4 commit 975e3cd

File tree

9 files changed

+27
-18
lines changed

9 files changed

+27
-18
lines changed

config/ompi_ext.m4

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -405,11 +405,15 @@ AC_DEFUN([EXT_CONFIGURE_M4_CONFIG_COMPONENT],[
405405
#--------------------
406406
#
407407
# C:
408-
# - c/mpiext_<component>_c.h: is included in mpi_ext.h
408+
# - c/mpiext_<component>_c.h: is installed to
409+
# <includedir>/openmpi/mpiext/mpiext_<component>_c.h and is included in
410+
# mpi_ext.h
409411
# - c/libmpiext_<component>.la: convneience library slurped into libmpi.la
410412
#
411413
# mpi.f.h:
412-
# - mpif-h/mpiext_<component>_mpifh.h: is included mpi mpif_ext.h
414+
# - mpif-h/mpiext_<component>_mpifh.h: is installed to
415+
# <includedir>openmpi/mpiext/mpiext_<component>_mpifh.h and is included mpi
416+
# mpif_ext.h
413417
# - mpif-h/libmpiext_<component>_mpifh.la: convenience library slurped
414418
# into libmpi_mpifh.la
415419
#
@@ -461,7 +465,7 @@ AC_DEFUN([EXT_PROCESS_COMPONENT],[
461465
###############
462466
# C Bindings
463467
###############
464-
test_header="${srcdir}/ompi/mpiext/$component/c/mpiext_${component}_c.h"
468+
test_header="${srcdir}/ompi/mpiext/${component}/c/mpiext_${component}_c.h"
465469

466470
AC_MSG_CHECKING([if MPI Extension $component has C bindings])
467471

@@ -479,14 +483,14 @@ AC_DEFUN([EXT_PROCESS_COMPONENT],[
479483
$3="$$3 $component"
480484

481485
# JMS Where is this needed?
482-
EXT_C_HEADERS="$EXT_C_HEADERS mpiext/$component/c/mpiext_${component}_c.h"
486+
EXT_C_HEADERS="$EXT_C_HEADERS mpiext/c/mpiext_${component}_c.h"
483487

484488
component_header="mpiext_${component}_c.h"
485489

486490
cat >> $mpi_ext_h <<EOF
487491
/* Enabled Extension: $component */
488492
#define $component_define 1
489-
#include "openmpi/ompi/mpiext/$component/c/$component_header"
493+
#include "openmpi/mpiext/$component_header"
490494

491495
EOF
492496

@@ -506,8 +510,7 @@ EOF
506510
AC_MSG_RESULT([yes])
507511
enabled_mpifh=1
508512

509-
# JMS Where is this needed?
510-
EXT_MPIFH_HEADERS="$EXT_MPIFH_HEADERS mpiext/$component/mpif-h/mpiext_${component}_mpifh.h"
513+
EXT_MPIFH_HEADERS="$EXT_MPIFH_HEADERS mpiext/mpiext_${component}_mpifh.h"
511514
$4="$$4 $component"
512515

513516
component_header="mpiext_${component}_mpifh.h"
@@ -519,7 +522,7 @@ EOF
519522
integer $component_define
520523
parameter ($component_define=1)
521524
522-
include 'openmpi/ompi/mpiext/$component/mpif-h/$component_header'
525+
include 'openmpi/mpiext/$component_header'
523526
524527
EOF
525528
else
@@ -550,7 +553,6 @@ EOF
550553
if test -e "$test_header" ; then
551554
AC_MSG_RESULT([yes])
552555

553-
# JMS Where is this needed?
554556
EXT_USEMPI_HEADERS="$EXT_USEMPI_HEADERS mpiext/$component/use-mpi/mpiext_${component}_usempi.h"
555557
$5="$$5 $component"
556558
component_header="mpiext_${component}_usempi.h"
@@ -602,7 +604,6 @@ EOF
602604
if test -e "$test_header" ; then
603605
AC_MSG_RESULT([yes])
604606

605-
# JMS Where is this needed?
606607
EXT_USEMPIF08_HEADERS="$EXT_USEMPIF08_HEADERS mpiext/$component/use-mpi-f08/mpiext_${component}_usempif08.h"
607608
$6="$$6 $component"
608609

ompi/mpiext/affinity/c/Makefile.am

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
# University Research and Technology
44
# Corporation. All rights reserved.
55
# Copyright (c) 2010-2014 Cisco Systems, Inc. All rights reserved.
6+
# Copyright (c) 2018 Research Organization for Information Science
7+
# and Technology (RIST). All rights reserved.
68
# $COPYRIGHT$
79
#
810
# Additional copyrights may follow
@@ -30,7 +32,7 @@ noinst_LTLIBRARIES = libmpiext_affinity_c.la
3032

3133
# This is where the top-level header file (that is included in
3234
# <mpi-ext.h>) must be installed.
33-
ompidir = $(ompiincludedir)/ompi/mpiext/affinity/c
35+
ompidir = $(ompiincludedir)/mpiext/
3436

3537
# This is the header file that is installed.
3638
ompi_HEADERS = mpiext_affinity_c.h

ompi/mpiext/cr/c/Makefile.am

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
# University Research and Technology
44
# Corporation. All rights reserved.
55
# Copyright (c) 2012 Cisco Systems, Inc. All rights reserved.
6+
# Copyright (c) 2018 Research Organization for Information Science
7+
# and Technology (RIST). All rights reserved.
68
# $COPYRIGHT$
79
#
810
# Additional copyrights may follow
@@ -22,7 +24,7 @@ noinst_LTLIBRARIES = libmpiext_cr_c.la
2224

2325
# This is where the top-level header file (that is included in
2426
# <mpi-ext.h>) must be installed.
25-
ompidir = $(ompiincludedir)/ompi/mpiext/cr/c
27+
ompidir = $(ompiincludedir)/mpiext
2628

2729
# This is the header file that is installed.
2830
ompi_HEADERS = mpiext_cr_c.h

ompi/mpiext/cuda/c/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ noinst_LTLIBRARIES = libmpiext_cuda_c.la
2727

2828
# This is where the top-level header file (that is included in
2929
# <mpi-ext.h>) must be installed.
30-
ompidir = $(ompiincludedir)/ompi/mpiext/cuda/c
30+
ompidir = $(ompiincludedir)/mpiext
3131

3232
# This is the header file that is installed.
3333
nodist_ompi_HEADERS = mpiext_cuda_c.h

ompi/mpiext/example/c/Makefile.am

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
# Corporation. All rights reserved.
55
# Copyright (c) 2011 Oak Ridge National Labs. All rights reserved.
66
# Copyright (c) 2011-2012 Cisco Systems, Inc. All rights reserved.
7+
# Copyright (c) 2018 Research Organization for Information Science
8+
# and Technology (RIST). All rights reserved.
79
# $COPYRIGHT$
810
#
911
# Additional copyrights may follow
@@ -23,7 +25,7 @@ noinst_LTLIBRARIES = libmpiext_example_c.la
2325

2426
# This is where the top-level header file (that is included in
2527
# <mpi-ext.h>) must be installed.
26-
ompidir = $(ompiincludedir)/ompi/mpiext/example/c
28+
ompidir = $(ompiincludedir)/mpiext
2729

2830
# This is the header file that is installed.
2931
ompi_HEADERS = mpiext_example_c.h

ompi/mpiext/example/mpif-h/Makefile.am

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
# Corporation. All rights reserved.
55
# Copyright (c) 2011 Oak Ridge National Labs. All rights reserved.
66
# Copyright (c) 2011-2012 Cisco Systems, Inc. All rights reserved.
7+
# Copyright (c) 2018 Research Organization for Information Science
8+
# and Technology (RIST). All rights reserved.
79
# $COPYRIGHT$
810
#
911
# Additional copyrights may follow
@@ -26,7 +28,7 @@ noinst_LTLIBRARIES =
2628

2729
# Directory where the header file to be included in mpif-ext.h must be
2830
# installed.
29-
ompidir = $(ompiincludedir)/ompi/mpiext/example/mpif-h
31+
ompidir = $(ompiincludedir)/mpiext
3032

3133
# Just like noinst_LTLIBRARIES, set this macro to empty and
3234
# conditionally add to it later.

ompi/mpiext/pcollreq/c/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ noinst_LTLIBRARIES = libmpiext_pcollreq_c.la
2323

2424
# This is where the top-level header file (that is included in
2525
# <mpi-ext.h>) must be installed.
26-
ompidir = $(ompiincludedir)/ompi/mpiext/pcollreq/c
26+
ompidir = $(ompiincludedir)/mpiext
2727

2828
# This is the header file that is installed.
2929
ompi_HEADERS = mpiext_pcollreq_c.h

ompi/mpiext/pcollreq/c/profile/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ noinst_LTLIBRARIES = libpmpiext_pcollreq_c.la
2222

2323
# This is where the top-level header file (that is included in
2424
# <mpi-ext.h>) must be installed.
25-
ompidir = $(ompiincludedir)/ompi/mpiext/pcollreq/c
25+
ompidir = $(ompiincludedir)/mpiext
2626

2727
# This is the header file that is installed.
2828
ompi_HEADERS = pmpiext_pcollreq_c.h

ompi/mpiext/pcollreq/mpif-h/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ noinst_LTLIBRARIES =
3131

3232
# Directory where the header file to be included in mpif-ext.h must be
3333
# installed.
34-
ompidir = $(ompiincludedir)/ompi/mpiext/pcollreq/mpif-h
34+
ompidir = $(ompiincludedir)/mpiext
3535

3636
# Just like noinst_LTLIBRARIES, set this macro to empty and
3737
# conditionally add to it later.

0 commit comments

Comments
 (0)