Skip to content

Commit 8ac79c9

Browse files
committed
ofi-common: fixes to some mca param reg bugs
this patch fixes a typo and mishandling of param indices thanks to @tomhers for catching these. Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
1 parent 25e0db6 commit 8ac79c9

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

opal/mca/common/ofi/common_ofi.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ OPAL_DECLSPEC int opal_common_ofi_register_mca_variables(const mca_base_componen
6666

6767
OPAL_THREAD_LOCK(&opal_common_ofi_mutex);
6868

69-
param = mca_base_var_find("opal", "opal_common", "ofi", "provider_incude");
69+
param = mca_base_var_find("opal", "opal_common", "ofi", "provider_include");
7070
if (0 > param) {
7171
/*
7272
* this monkey business is needed because of the way the MCA VARs stuff tries to handle
@@ -86,6 +86,8 @@ OPAL_DECLSPEC int opal_common_ofi_register_mca_variables(const mca_base_componen
8686
"exclusive with mtl_ofi_provider_exclude.",
8787
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_1, MCA_BASE_VAR_SCOPE_READONLY,
8888
opal_common_ofi.prov_include);
89+
} else {
90+
include_index = param;
8991
}
9092

9193
param = mca_base_var_find("opal", "opal_common", "ofi", "provider_exclude");
@@ -102,6 +104,8 @@ OPAL_DECLSPEC int opal_common_ofi_register_mca_variables(const mca_base_componen
102104
"exclusive with mtl_ofi_provider_include.",
103105
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_1, MCA_BASE_VAR_SCOPE_READONLY,
104106
opal_common_ofi.prov_exclude);
107+
} else {
108+
exclude_index = param;
105109
}
106110

107111
param = mca_base_var_find("opal", "opal_common", "ofi", "verbose");
@@ -112,6 +116,8 @@ OPAL_DECLSPEC int opal_common_ofi_register_mca_variables(const mca_base_componen
112116
MCA_BASE_VAR_FLAG_SETTABLE, OPAL_INFO_LVL_3,
113117
MCA_BASE_VAR_SCOPE_LOCAL,
114118
&opal_common_ofi.verbose);
119+
} else {
120+
verbose_index = param;
115121
}
116122

117123
if (component) {

0 commit comments

Comments
 (0)