Fix memory leak in mca_btl_tcp_proc_handle_modex_addresses

David Wootton · David Wootton · commit 8a798fd3bdd1 · 2022-12-07T16:24:48.000-05:00
Coverity CID 1458001

Signed-off-by: David Wootton &lt;dwootton@us.ibm.com&gt;
diff --git a/opal/mca/btl/tcp/btl_tcp_proc.c b/opal/mca/btl/tcp/btl_tcp_proc.c
@@ -347,14 +347,12 @@ static int mca_btl_tcp_proc_handle_modex_addresses(mca_btl_tcp_proc_t *btl_proc,
 
     rc = mca_btl_tcp_proc_store_matched_interfaces(btl_proc, local_proc_is_left, graph, num_matched,
                                                    matched_edges);
-    if (rc) {
-        goto cleanup;
-    }
 
 cleanup:
     if (NULL != graph) {
         opal_bp_graph_free(graph);
     }
+    free(matched_edges);
     return rc;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -347,14 +347,12 @@ static int mca_btl_tcp_proc_handle_modex_addresses(mca_btl_tcp_proc_t *btl_proc,`
`347`	`347`
`348`	`348`	`rc = mca_btl_tcp_proc_store_matched_interfaces(btl_proc, local_proc_is_left, graph, num_matched,`
`349`	`349`	`matched_edges);`
`350`		`- if (rc) {`
`351`		`- goto cleanup;`
`352`		`- }`
`353`	`350`
`354`	`351`	`cleanup:`
`355`	`352`	`if (NULL != graph) {`
`356`	`353`	`opal_bp_graph_free(graph);`
`357`	`354`	`}`
	`355`	`+ free(matched_edges);`
`358`	`356`	`return rc;`
`359`	`357`	`}`
`360`	`358`