Skip to content

Commit 8251139

Browse files
committed
status_set_cancelled: fix F08 binding
The F08 bindings for MPI_STATUS_SET_CANCELLED incorrectly had the "flag" dummy parameter set as INTENT(OUT) when it really should be INTENT(IN). On the one hand, this is technically an ABI change. On the other hand, this is an incorrect MPI binding. On the other hand (that's 3 hands for you fans counting at home), this is such a rarely-used API -- even in the C bindings -- that I'm guessing no one is using this API, and therefore no one has noticed this error and it isn't worth porting back to the release branches. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
1 parent 69456c8 commit 8251139

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

ompi/mpi/fortran/use-mpi-f08/mod/mpi-f08-interfaces.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
! -*- f90 -*-
22
!
3-
! Copyright (c) 2009-2015 Cisco Systems, Inc. All rights reserved.
3+
! Copyright (c) 2009-2018 Cisco Systems, Inc. All rights reserved
44
! Copyright (c) 2009-2015 Los Alamos National Security, LLC.
55
! All rights reserved.
66
! Copyright (c) 2012 The University of Tennessee and The University
@@ -3503,7 +3503,7 @@ subroutine MPI_Status_set_cancelled_f08(status,flag,ierror)
35033503
use :: mpi_f08_types, only : MPI_Status
35043504
implicit none
35053505
TYPE(MPI_Status), INTENT(INOUT) :: status
3506-
LOGICAL, INTENT(OUT) :: flag
3506+
LOGICAL, INTENT(IN) :: flag
35073507
INTEGER, OPTIONAL, INTENT(OUT) :: ierror
35083508
end subroutine MPI_Status_set_cancelled_f08
35093509
end interface MPI_Status_set_cancelled

ompi/mpi/fortran/use-mpi-f08/mod/pmpi-f08-interfaces.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
! -*- f90 -*-
22
!
3-
! Copyright (c) 2009-2015 Cisco Systems, Inc. All rights reserved.
3+
! Copyright (c) 2009-2018 Cisco Systems, Inc. All rights reserved
44
! Copyright (c) 2009-2013 Los Alamos National Security, LLC.
55
! All rights reserved.
66
! Copyright (c) 2012 The University of Tennessee and The University
@@ -3503,7 +3503,7 @@ subroutine PMPI_Status_set_cancelled_f08(status,flag,ierror)
35033503
use :: mpi_f08_types, only : MPI_Status
35043504
implicit none
35053505
TYPE(MPI_Status), INTENT(INOUT) :: status
3506-
LOGICAL, INTENT(OUT) :: flag
3506+
LOGICAL, INTENT(IN) :: flag
35073507
INTEGER, OPTIONAL, INTENT(OUT) :: ierror
35083508
end subroutine PMPI_Status_set_cancelled_f08
35093509
end interface PMPI_Status_set_cancelled

ompi/mpi/fortran/use-mpi-f08/profile/pstatus_set_cancelled_f08.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
! -*- f90 -*-
22
!
3-
! Copyright (c) 2010-2013 Cisco Systems, Inc. All rights reserved.
3+
! Copyright (c) 2010-2018 Cisco Systems, Inc. All rights reserved
44
! Copyright (c) 2009-2012 Los Alamos National Security, LLC.
55
! All Rights reserved.
66
! $COPYRIGHT$
@@ -9,7 +9,7 @@ subroutine PMPI_Status_set_cancelled_f08(status,flag,ierror)
99
use :: mpi_f08_types, only : MPI_Status
1010
implicit none
1111
TYPE(MPI_Status), INTENT(INOUT) :: status
12-
LOGICAL, INTENT(OUT) :: flag
12+
LOGICAL, INTENT(IN) :: flag
1313
INTEGER, OPTIONAL, INTENT(OUT) :: ierror
1414
integer :: c_ierror
1515

ompi/mpi/fortran/use-mpi-f08/status_set_cancelled_f08.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
! -*- f90 -*-
22
!
3-
! Copyright (c) 2010-2013 Cisco Systems, Inc. All rights reserved.
3+
! Copyright (c) 2010-2018 Cisco Systems, Inc. All rights reserved
44
! Copyright (c) 2009-2012 Los Alamos National Security, LLC.
55
! All Rights reserved.
66
! $COPYRIGHT$
@@ -9,7 +9,7 @@ subroutine MPI_Status_set_cancelled_f08(status,flag,ierror)
99
use :: mpi_f08_types, only : MPI_Status
1010
implicit none
1111
TYPE(MPI_Status), INTENT(INOUT) :: status
12-
LOGICAL, INTENT(OUT) :: flag
12+
LOGICAL, INTENT(IN) :: flag
1313
INTEGER, OPTIONAL, INTENT(OUT) :: ierror
1414
integer :: c_ierror
1515

0 commit comments

Comments
 (0)