Skip to content

Commit 81bfb5f

Browse files
committed
Remove some IMPI attributes that were never implemented.
This is a holdover from LAM/MPI that was never implemented here in Open MPI (and never will be). Might as well remove this dead code. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
1 parent cf49957 commit 81bfb5f

File tree

2 files changed

+3
-43
lines changed

2 files changed

+3
-43
lines changed

ompi/attribute/attribute_predefined.c

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,6 @@
7474
* doesn't make sense to copy them to new windows (because they're
7575
* values specific and unique to each window) -- especially when
7676
* WIN_CREATE will explicitly set them on new windows anyway.
77-
*
78-
* These are not supported yet, but are included here for consistency:
79-
*
80-
* MPI_IMPI_CLIENT_SIZE, MPI_IMPI_CLIENT_COLOR, MPI_IMPI_HOST_SIZE,
81-
* and MPI_IMPI_HOST_COLOR are integer-valued attributes.
8277
*/
8378

8479
#include "ompi_config.h"
@@ -128,15 +123,7 @@ int ompi_attr_create_predefined(void)
128123
OMPI_SUCCESS != (ret = create_win(MPI_WIN_SIZE)) ||
129124
OMPI_SUCCESS != (ret = create_win(MPI_WIN_DISP_UNIT)) ||
130125
OMPI_SUCCESS != (ret = create_win(MPI_WIN_CREATE_FLAVOR)) ||
131-
OMPI_SUCCESS != (ret = create_win(MPI_WIN_MODEL)) ||
132-
#if 0
133-
/* JMS For when we implement IMPI */
134-
OMPI_SUCCESS != (ret = create_comm(IMPI_CLIENT_SIZE, true)) ||
135-
OMPI_SUCCESS != (ret = create_comm(IMPI_CLIENT_COLOR, true)) ||
136-
OMPI_SUCCESS != (ret = create_comm(IMPI_HOST_SIZE, true)) ||
137-
OMPI_SUCCESS != (ret = create_comm(IMPI_HOST_COLOR, true)) ||
138-
#endif
139-
0) {
126+
OMPI_SUCCESS != (ret = create_win(MPI_WIN_MODEL))) {
140127
return ret;
141128
}
142129

@@ -147,19 +134,7 @@ int ompi_attr_create_predefined(void)
147134
OMPI_SUCCESS != (ret = set_f(MPI_IO, MPI_ANY_SOURCE)) ||
148135
OMPI_SUCCESS != (ret = set_f(MPI_WTIME_IS_GLOBAL, 0)) ||
149136
OMPI_SUCCESS != (ret = set_f(MPI_LASTUSEDCODE,
150-
ompi_mpi_errcode_lastused)) ||
151-
#if 0
152-
/* JMS For when we implement IMPI */
153-
OMPI_SUCCESS != (ret = set(IMPI_CLIENT_SIZE,
154-
&attr_impi_client_size)) ||
155-
OMPI_SUCCESS != (ret = set(IMPI_CLIENT_COLOR,
156-
&attr_impi_client_color)) ||
157-
OMPI_SUCCESS != (ret = set(IMPI_HOST_SIZE,
158-
&attr_impi_host_size)) ||
159-
OMPI_SUCCESS != (ret = set(IMPI_HOST_COLOR,
160-
&attr_impi_host_color)) ||
161-
#endif
162-
0) {
137+
ompi_mpi_errcode_lastused))) {
163138
return ret;
164139
}
165140

@@ -196,15 +171,7 @@ int ompi_attr_free_predefined(void)
196171
OMPI_SUCCESS != (ret = free_win(MPI_WIN_SIZE)) ||
197172
OMPI_SUCCESS != (ret = free_win(MPI_WIN_DISP_UNIT)) ||
198173
OMPI_SUCCESS != (ret = free_win(MPI_WIN_CREATE_FLAVOR)) ||
199-
OMPI_SUCCESS != (ret = free_win(MPI_WIN_MODEL)) ||
200-
#if 0
201-
/* JMS For when we implement IMPI */
202-
OMPI_SUCCESS != (ret = free_comm(IMPI_CLIENT_SIZE)) ||
203-
OMPI_SUCCESS != (ret = free_comm(IMPI_CLIENT_COLOR)) ||
204-
OMPI_SUCCESS != (ret = free_comm(IMPI_HOST_SIZE)) ||
205-
OMPI_SUCCESS != (ret = free_comm(IMPI_HOST_COLOR)) ||
206-
#endif
207-
0) {
174+
OMPI_SUCCESS != (ret = free_win(MPI_WIN_MODEL))) {
208175
return ret;
209176
}
210177
return OMPI_SUCCESS;

ompi/include/mpi.h.in

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -521,13 +521,6 @@ enum {
521521
MPI_WIN_DISP_UNIT,
522522
MPI_WIN_CREATE_FLAVOR,
523523
MPI_WIN_MODEL,
524-
525-
/* Even though these four are IMPI attributes, they need to be there
526-
for all MPI jobs */
527-
IMPI_CLIENT_SIZE,
528-
IMPI_CLIENT_COLOR,
529-
IMPI_HOST_SIZE,
530-
IMPI_HOST_COLOR
531524
};
532525

533526
/*

0 commit comments

Comments
 (0)