btl/openib: fix a problem with ib query

hppritcha · hppritcha · commit 8126779a354b · 2018-10-31T14:50:15.000-06:00
Under certain circumstances, ibv_exp_query_device was returning an error due to uninitialized fields in the extended attributes struct. Fixes: #5810 Fixes: #5914 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
diff --git a/opal/mca/btl/openib/btl_openib_component.c b/opal/mca/btl/openib/btl_openib_component.c
@@ -1694,6 +1694,7 @@ static int init_one_device(opal_list_t *btl_list, struct ibv_device* ib_dev)
         goto error;
     }
 #if HAVE_DECL_IBV_EXP_QUERY_DEVICE
+    memset(&device->ib_exp_dev_attr, 0, sizeof(device->ib_exp_dev_attr));
     device->ib_exp_dev_attr.comp_mask = IBV_EXP_DEVICE_ATTR_RESERVED - 1;
     if(ibv_exp_query_device(device->ib_dev_context, &device->ib_exp_dev_attr)){
         BTL_ERROR(("error obtaining device attributes for %s errno says %s",

Original file line number	Diff line number	Diff line change
`@@ -1694,6 +1694,7 @@ static int init_one_device(opal_list_t btl_list, struct ibv_device ib_dev)`
`1694`	`1694`	`goto error;`
`1695`	`1695`	`}`
`1696`	`1696`	`#if HAVE_DECL_IBV_EXP_QUERY_DEVICE`
	`1697`	`+ memset(&device->ib_exp_dev_attr, 0, sizeof(device->ib_exp_dev_attr));`
`1697`	`1698`	`device->ib_exp_dev_attr.comp_mask = IBV_EXP_DEVICE_ATTR_RESERVED - 1;`
`1698`	`1699`	`if(ibv_exp_query_device(device->ib_dev_context, &device->ib_exp_dev_attr)){`
`1699`	`1700`	`BTL_ERROR(("error obtaining device attributes for %s errno says %s",`