Skip to content

Commit 810c3b1

Browse files
committed
wrapper: Fix mis-application of flags filter
Fix a bug introduced with 5d23e0, where we were filtering out standard paths from preprocessor flags instead of compiler flags. In practice, this didn't change any behaviors because we wanted to filter preprocessor flags (and already had, so this call was a no-op) and we never put -Is in compiler flags. But it's a mistake and Coverity found it, so fix it. Fixes CID 1503336. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
1 parent 52ed8bc commit 810c3b1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

opal/tools/wrappers/opal_wrapper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ static void data_callback(const char *key, const char *value)
402402
opal_argv_insert(&options_data[parse_options_idx].comp_flags,
403403
opal_argv_count(options_data[parse_options_idx].comp_flags), values);
404404
expand_flags(options_data[parse_options_idx].comp_flags);
405-
filter_flags(&options_data[parse_options_idx].preproc_flags);
405+
filter_flags(&options_data[parse_options_idx].comp_flags);
406406
opal_argv_free(values);
407407
} else if (0 == strcmp(key, "compiler_flags_prefix")) {
408408
char **values = opal_argv_split(value, ' ');

0 commit comments

Comments
 (0)