Fix memory leak in do_recv (memheap_base_mkey.c)

David Wootton · David Wootton · commit 7eea38c87a0f · 2022-12-05T14:45:39.000-05:00
Coverity CID 1498655

Signed-off-by: David Wootton &lt;dwootton@us.ibm.com&gt;
diff --git a/oshmem/mca/memheap/base/memheap_base_mkey.c b/oshmem/mca/memheap/base/memheap_base_mkey.c
@@ -235,6 +235,7 @@ static void do_recv(int source_pe, pmix_data_buffer_t* buffer)
         if (MPI_SUCCESS != rc) {
             MEMHEAP_ERROR("FAILED to send rml message %d", rc);
             OMPI_ERROR_LOG(rc);
+            OBJ_RELEASE(msg);
             goto send_fail;
         }
         break;
@@ -274,6 +275,7 @@ static void do_recv(int source_pe, pmix_data_buffer_t* buffer)
     if (MPI_SUCCESS != rc) {
         MEMHEAP_ERROR("FAILED to send rml message %d", rc);
         OMPI_ERROR_LOG(rc);
+        OBJ_RELEASE(msg);
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,7 @@ static void do_recv(int source_pe, pmix_data_buffer_t* buffer)`
`235`	`235`	`if (MPI_SUCCESS != rc) {`
`236`	`236`	`MEMHEAP_ERROR("FAILED to send rml message %d", rc);`
`237`	`237`	`OMPI_ERROR_LOG(rc);`
	`238`	`+ OBJ_RELEASE(msg);`
`238`	`239`	`goto send_fail;`
`239`	`240`	`}`
`240`	`241`	`break;`
`@@ -274,6 +275,7 @@ static void do_recv(int source_pe, pmix_data_buffer_t* buffer)`
`274`	`275`	`if (MPI_SUCCESS != rc) {`
`275`	`276`	`MEMHEAP_ERROR("FAILED to send rml message %d", rc);`
`276`	`277`	`OMPI_ERROR_LOG(rc);`
	`278`	`+ OBJ_RELEASE(msg);`
`277`	`279`	`}`
`278`	`280`
`279`	`281`	`}`