Fix memory leak in start_dvm

David Wootton · David Wootton · commit 7bdb4dd6a806 · 2022-12-07T11:17:46.000-05:00
Coverity CID 1490117

Signed-off-by: David Wootton &lt;dwootton@us.ibm.com&gt;
diff --git a/ompi/dpm/dpm.c b/ompi/dpm/dpm.c
@@ -1998,6 +1998,7 @@ static int start_dvm(char **hostfiles, char **dash_host)
      */
     if (pipe(p) < 0) {
         OMPI_ERROR_LOG(OMPI_ERROR);
+        free(cmd);
         return OMPI_ERROR;
     }
 
@@ -2010,6 +2011,7 @@ static int start_dvm(char **hostfiles, char **dash_host)
         OMPI_ERROR_LOG(OMPI_ERROR);
         close(p[0]);
         close(p[1]);
+        free(cmd);
         return OMPI_ERROR;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1998,6 +1998,7 @@ static int start_dvm(char hostfiles, char dash_host)`
`1998`	`1998`	`*/`
`1999`	`1999`	`if (pipe(p) < 0) {`
`2000`	`2000`	`OMPI_ERROR_LOG(OMPI_ERROR);`
	`2001`	`+ free(cmd);`
`2001`	`2002`	`return OMPI_ERROR;`
`2002`	`2003`	`}`
`2003`	`2004`
`@@ -2010,6 +2011,7 @@ static int start_dvm(char hostfiles, char dash_host)`
`2010`	`2011`	`OMPI_ERROR_LOG(OMPI_ERROR);`
`2011`	`2012`	`close(p[0]);`
`2012`	`2013`	`close(p[1]);`
	`2014`	`+ free(cmd);`
`2013`	`2015`	`return OMPI_ERROR;`
`2014`	`2016`	`}`
`2015`	`2017`