Fix uninitialized variable

rhc54 · rhc54 · commit 7acf1f15b245 · 2022-09-02T07:47:22.000-07:00
Variable "dirs" is passed to the PMIx function without being
initialized when the "#if" clause is false.

Signed-off-by: Ralph Castain &lt;rhc@pmix.org&gt;
diff --git a/opal/util/show_help.c b/opal/util/show_help.c
@@ -134,7 +134,7 @@ static void opal_show_help_cbfunc(pmix_status_t status, void *cbdata)
 }
 
 static void local_delivery(const char *file, const char *topic, char *msg) {
-    pmix_info_t *info, *dirs;
+    pmix_info_t *info, *dirs = NULL;
     int ninfo = 0, ndirs = 0;
     PMIX_INFO_CREATE(info, 1);
     PMIX_INFO_LOAD(&info[ninfo++], PMIX_LOG_STDERR, msg, PMIX_STRING);

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ static void opal_show_help_cbfunc(pmix_status_t status, void *cbdata)`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`static void local_delivery(const char file, const char topic, char *msg) {`
`137`		`- pmix_info_t info, dirs;`
	`137`	`+ pmix_info_t info, dirs = NULL;`
`138`	`138`	`int ninfo = 0, ndirs = 0;`
`139`	`139`	`PMIX_INFO_CREATE(info, 1);`
`140`	`140`	`PMIX_INFO_LOAD(&info[ninfo++], PMIX_LOG_STDERR, msg, PMIX_STRING);`