btl/ofi: Fix valgrind complaints on uninitialized pointer use

aravindksg · aravindksg · commit 786e686d4347 · 2019-02-01T14:03:23.000-08:00
It doesn't seem like the BTL was using uninitialized pointer. But simply setting the rcache pointer to NULL after destroying it makes the valgrind errors go away. Fixes Issue #6345 Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@intel.com>
diff --git a/opal/mca/btl/ofi/btl_ofi_module.c b/opal/mca/btl/ofi/btl_ofi_module.c
@@ -315,6 +315,7 @@ int mca_btl_ofi_finalize (mca_btl_base_module_t* btl)
 
     if (ofi_btl->rcache) {
         mca_rcache_base_module_destroy (ofi_btl->rcache);
+        ofi_btl->rcache = NULL;
     }
 
     free (btl);

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,7 @@ int mca_btl_ofi_finalize (mca_btl_base_module_t* btl)`
`315`	`315`
`316`	`316`	`if (ofi_btl->rcache) {`
`317`	`317`	`mca_rcache_base_module_destroy (ofi_btl->rcache);`
	`318`	`+ ofi_btl->rcache = NULL;`
`318`	`319`	`}`
`319`	`320`
`320`	`321`	`free (btl);`