Use opal_asprintf instead of asprintf

A couple places where using asprintf and not paying attention to return
values was causing warnings.  Use opal_asprintf instead, which has known
behavior with the return pointer on failure and so we can safely ignore
return values.

Signed-off-by: Brian Barrett <bbarrett@amazon.com>

Author: bwbarrett

ompi/mca/sharedfp/sm/sharedfp_sm.c

@@ -28,6 +28,7 @@
 
 #include "ompi_config.h"
 #include "mpi.h"
+#include "opal/util/printf.h"
 #include "ompi/mca/sharedfp/sharedfp.h"
 #include "ompi/mca/sharedfp/base/base.h"
 #include "ompi/mca/sharedfp/sm/sharedfp_sm.h"
@@ -105,7 +106,7 @@ struct mca_sharedfp_base_module_1_0_0_t * mca_sharedfp_sm_component_file_query(o
     int comm_cid = -1;
     int pid = ompi_comm_rank (comm);
 
-    asprintf(&sm_filename, "%s/%s_cid-%d-%d.sm", ompi_process_info.job_session_dir,
+    opal_asprintf(&sm_filename, "%s/%s_cid-%d-%d.sm", ompi_process_info.job_session_dir,
              filename_basename, comm_cid, pid);
     free(filename_basename);
 

ompi/mca/sharedfp/sm/sharedfp_sm_file_open.c

@@ -35,6 +35,7 @@
 #include "sharedfp_sm.h"
 
 #include "mpi.h"
+#include "opal/util/printf.h"
 #include "opal/util/output.h"
 #include "ompi/constants.h"
 #include "ompi/group/group.h"
@@ -120,8 +121,8 @@ int mca_sharedfp_sm_file_open (struct ompi_communicator_t *comm,
         return err;
     }
 
-    asprintf(&sm_filename, "%s/%s_cid-%d-%d.sm", ompi_process_info.job_session_dir,
-             filename_basename, comm_cid, int_pid);
+    opal_asprintf(&sm_filename, "%s/%s_cid-%d-%d.sm", ompi_process_info.job_session_dir,
+                  filename_basename, comm_cid, int_pid);
     /* open shared memory file, initialize to 0, map into memory */
     sm_fd = open(sm_filename, O_RDWR | O_CREAT,
                  S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

ompi/tools/mpirun/main.c

@@ -23,6 +23,7 @@
 #include "opal/util/os_dirpath.h"
 #include "opal/util/os_path.h"
 #include "opal/util/path.h"
+#include "opal/util/printf.h"
 
 int main(int argc, char *argv[])
 {
@@ -35,12 +36,12 @@ int main(int argc, char *argv[])
     if (NULL != (evar = getenv("OPAL_PREFIX"))) {
 
 #if OMPI_USING_INTERNAL_PRRTE
-        (void)asprintf(&pvar, "PRTE_PREFIX=%s", evar);
+        opal_asprintf(&pvar, "PRTE_PREFIX=%s", evar);
         putenv(pvar);
 #endif
 
 #if OPAL_USING_INTERNAL_PMIX
-        (void)asprintf(&pvar, "PMIX_PREFIX=%s", evar);
+        opal_asprintf(&pvar, "PMIX_PREFIX=%s", evar);
         putenv(pvar);
 #endif
     }
@@ -51,7 +52,7 @@ int main(int argc, char *argv[])
         opal_argv_append_nosize(&pargs, argv[m]);
         /* Did the user specify a prefix, or want prefix by default? */
         if (0 == strcmp(argv[m], "--prefix")) {
-            asprintf(&pfx, "%s%s", argv[m+1], "/bin");
+            opal_asprintf(&pfx, "%s%s", argv[m+1], "/bin");
         }
     }