Make error_class and error_string callable before/after

abouteiller · abouteiller · commit 703b8c356f85 · 2020-07-16T03:10:32.000-04:00
MPI_INIT/FINALIZE

Signed-off-by: Aurélien Bouteiller &lt;bouteill@icl.utk.edu&gt;

make lazy initialization opal unlikely

Signed-off-by: Aurelien Bouteiller &lt;bouteill@icl.utk.edu&gt;
diff --git a/ompi/errhandler/errcode.c b/ompi/errhandler/errcode.c
@@ -131,8 +131,17 @@ do {                                                                      \
     opal_pointer_array_set_item(&ompi_mpi_errcodes, (ERRCODE), &(VAR));   \
 } while (0)
 
+static opal_mutex_t errcode_init_lock = OPAL_MUTEX_STATIC_INIT;
+
 int ompi_mpi_errcode_init (void)
 {
+    opal_mutex_lock(&errcode_init_lock);
+    if ( 0 != ompi_mpi_errcode_lastpredefined ) {
+        /* Already initialized (presumably by an API call before MPI_init */
+        opal_mutex_unlock(&errcode_init_lock);
+        return OMPI_SUCCESS;
+    }
+
     /* Initialize the pointer array, which will hold the references to
        the error objects */
     OBJ_CONSTRUCT(&ompi_mpi_errcodes, opal_pointer_array_t);
@@ -223,6 +232,7 @@ int ompi_mpi_errcode_init (void)
        MPI_ERR_LASTCODE.  So just start it as == MPI_ERR_LASTCODE. */
     ompi_mpi_errcode_lastused = MPI_ERR_LASTCODE;
     ompi_mpi_errcode_lastpredefined = MPI_ERR_LASTCODE;
+    opal_mutex_unlock(&errcode_init_lock);
     return OMPI_SUCCESS;
 }
 
@@ -231,6 +241,7 @@ int ompi_mpi_errcode_finalize(void)
     int i;
     ompi_mpi_errcode_t *errc;
 
+    opal_mutex_lock(&errcode_init_lock);
     for (i=ompi_mpi_errcode_lastpredefined+1; i<=ompi_mpi_errcode_lastused; i++) {
         /*
          * there are some user defined error-codes, which
@@ -317,6 +328,8 @@ int ompi_mpi_errcode_finalize(void)
     OBJ_DESTRUCT(&ompi_t_err_invalid_name);
 
     OBJ_DESTRUCT(&ompi_mpi_errcodes);
+    ompi_mpi_errcode_lastpredefined = 0;
+    opal_mutex_unlock(&errcode_init_lock);
     return OMPI_SUCCESS;
 }
 
diff --git a/ompi/errhandler/errcode.h b/ompi/errhandler/errcode.h
@@ -3,7 +3,7 @@
  * Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
  *                         University Research and Technology
  *                         Corporation.  All rights reserved.
- * Copyright (c) 2004-2007 The University of Tennessee and The University
+ * Copyright (c) 2004-2020 The University of Tennessee and The University
  *                         of Tennessee Research Foundation.  All rights
  *                         reserved.
  * Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
@@ -55,11 +55,68 @@ OMPI_DECLSPEC extern int ompi_mpi_errcode_lastpredefined;
 
 OMPI_DECLSPEC extern ompi_mpi_errcode_t ompi_err_unknown;
 
+/**
+ * Initialize the error codes
+ *
+ * @returns OMPI_SUCCESS Upon success
+ * @returns OMPI_ERROR Otherwise
+ *
+ * Invoked from ompi_mpi_init(); sets up all static MPI error codes,
+ */
+int ompi_mpi_errcode_init(void);
+
+/**
+ * Finalize the error codes.
+ *
+ * @returns OMPI_SUCCESS Always
+ *
+ * Invokes from ompi_mpi_finalize(); tears down the error code array.
+ */
+int ompi_mpi_errcode_finalize(void);
+
+/**
+ * Add an error code
+ *
+ * @param: error class to which this new error code belongs to
+ *
+ * @returns the new error code on SUCCESS (>0)
+ * @returns OMPI_ERROR otherwise
+ *
+ */
+int ompi_mpi_errcode_add (int errclass);
+
+/**
+ * Add an error class
+ *
+ * @param: none
+ *
+ * @returns the new error class on SUCCESS (>0)
+ * @returns OMPI_ERROR otherwise
+ *
+ */
+int ompi_mpi_errclass_add (void);
+
+/**
+ * Add an error string to an error code
+ *
+ * @param: error code for which the string is defined
+ * @param: error string to add
+ * @param: length of the string
+ *
+ * @returns OMPI_SUCCESS on success
+ * @returns OMPI_ERROR on error
+ */
+int ompi_mpi_errnum_add_string (int errnum, const char* string, int len);
+
 /**
  * Check for a valid error code
  */
 static inline bool ompi_mpi_errcode_is_invalid(int errcode)
 {
+    if (OPAL_UNLIKELY( 0 == ompi_mpi_errcode_lastpredefined )) {
+        ompi_mpi_errcode_init();
+    }
+
     if ( errcode >= 0 && errcode <= ompi_mpi_errcode_lastused )
         return 0;
     else
@@ -73,23 +130,31 @@ static inline int ompi_mpi_errcode_get_class (int errcode)
 {
     ompi_mpi_errcode_t *err = NULL;
 
+    if (OPAL_UNLIKELY( 0 == ompi_mpi_errcode_lastpredefined )) {
+        ompi_mpi_errcode_init();
+    }
+
     if (errcode >= 0) {
         err = (ompi_mpi_errcode_t *)opal_pointer_array_get_item(&ompi_mpi_errcodes, errcode);
         /* If we get a bogus errcode, return MPI_ERR_UNKNOWN */
     }
 
     if (NULL != err) {
-	if ( err->code != MPI_UNDEFINED ) {
-	    return err->cls;
-	}
+        if ( err->code != MPI_UNDEFINED ) {
+            return err->cls;
+        }
     }
     return ompi_err_unknown.cls;
 }
 
 static inline int ompi_mpi_errcode_is_predefined ( int errcode )
 {
+    if (OPAL_UNLIKELY( 0 == ompi_mpi_errcode_lastpredefined )) {
+        ompi_mpi_errcode_init();
+    }
+
     if ( errcode >= 0 && errcode <= ompi_mpi_errcode_lastpredefined )
-	return true;
+        return true;
 
     return false;
 }
@@ -98,23 +163,27 @@ static inline int ompi_mpi_errnum_is_class ( int errnum )
 {
     ompi_mpi_errcode_t *err;
 
+    if (OPAL_UNLIKELY( 0 == ompi_mpi_errcode_lastpredefined )) {
+        ompi_mpi_errcode_init();
+    }
+
     if (errnum < 0) {
         return false;
     }
 
     if ( errnum <= ompi_mpi_errcode_lastpredefined ) {
-	/* Predefined error values represent an error code and
-	   an error class at the same time */
-	return true;
+        /* Predefined error values represent an error code and
+           an error class at the same time */
+        return true;
     }
 
     err = (ompi_mpi_errcode_t *)opal_pointer_array_get_item(&ompi_mpi_errcodes, errnum);
     if (NULL != err) {
-	if ( MPI_UNDEFINED == err->code) {
-	    /* Distinction between error class and error code is that for the
-	       first one the code section is set to MPI_UNDEFINED  */
-	    return true;
-	}
+        if ( MPI_UNDEFINED == err->code) {
+            /* Distinction between error class and error code is that for the
+               first one the code section is set to MPI_UNDEFINED  */
+            return true;
+        }
     }
 
     return false;
@@ -128,6 +197,10 @@ static inline char* ompi_mpi_errnum_get_string (int errnum)
 {
     ompi_mpi_errcode_t *err = NULL;
 
+    if (OPAL_UNLIKELY( 0 == ompi_mpi_errcode_lastpredefined )) {
+        ompi_mpi_errcode_init();
+    }
+
     if (errnum >= 0) {
         err = (ompi_mpi_errcode_t *)opal_pointer_array_get_item(&ompi_mpi_errcodes, errnum);
         /* If we get a bogus errcode, return a string indicating that this
@@ -142,59 +215,6 @@ static inline char* ompi_mpi_errnum_get_string (int errnum)
 }
 
 
-/**
- * Initialize the error codes
- *
- * @returns OMPI_SUCCESS Upon success
- * @returns OMPI_ERROR Otherwise
- *
- * Invoked from ompi_mpi_init(); sets up all static MPI error codes,
- */
-int ompi_mpi_errcode_init(void);
-
-/**
- * Finalize the error codes.
- *
- * @returns OMPI_SUCCESS Always
- *
- * Invokes from ompi_mpi_finalize(); tears down the error code array.
- */
-int ompi_mpi_errcode_finalize(void);
-
-/**
- * Add an error code
- *
- * @param: error class to which this new error code belongs to
- *
- * @returns the new error code on SUCCESS (>0)
- * @returns OMPI_ERROR otherwise
- *
- */
-int ompi_mpi_errcode_add (int errclass);
-
-/**
- * Add an error class
- *
- * @param: none
- *
- * @returns the new error class on SUCCESS (>0)
- * @returns OMPI_ERROR otherwise
- *
- */
-int ompi_mpi_errclass_add (void);
-
-/**
- * Add an error string to an error code
- *
- * @param: error code for which the string is defined
- * @param: error string to add
- * @param: length of the string
- *
- * @returns OMPI_SUCCESS on success
- * @returns OMPI_ERROR on error
- */
-int ompi_mpi_errnum_add_string (int errnum, const char* string, int len);
-
 END_C_DECLS
 
 #endif /* OMPI_MPI_ERRCODE_H */
diff --git a/ompi/mpi/c/error_class.c b/ompi/mpi/c/error_class.c
@@ -42,11 +42,22 @@ int MPI_Error_class(int errorcode, int *errorclass)
     OPAL_CR_NOOP_PROGRESS();
 
     if ( MPI_PARAM_CHECK ) {
-        OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
-
         if ( ompi_mpi_errcode_is_invalid(errorcode)) {
-            return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
-                                          FUNC_NAME);
+            /* If we have an error, the action that we take depends on
+               whether we're currently (after MPI_Init and before
+               MPI_Finalize) or not */
+            int32_t state = ompi_mpi_state;
+            if (state >= OMPI_MPI_STATE_INIT_COMPLETED &&
+                state < OMPI_MPI_STATE_FINALIZE_PAST_COMM_SELF_DESTRUCT) {
+               return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
+                                              FUNC_NAME);
+            } else {
+                /* We have no MPI object here so call ompi_errhandle_invoke
+                 * directly */
+                return ompi_errhandler_invoke(NULL, NULL, -1,
+                                              ompi_errcode_get_mpi_code(MPI_ERR_ARG),
+                                              FUNC_NAME);
+            }
         }
     }
 
diff --git a/ompi/mpi/c/error_string.c b/ompi/mpi/c/error_string.c
@@ -47,11 +47,22 @@ int MPI_Error_string(int errorcode, char *string, int *resultlen)
     OPAL_CR_NOOP_PROGRESS();
 
     if ( MPI_PARAM_CHECK ) {
-        OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
-
         if ( ompi_mpi_errcode_is_invalid(errorcode)) {
-            return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
-                                          FUNC_NAME);
+            /* If we have an error, the action that we take depends on
+               whether we're currently (after MPI_Init and before
+               MPI_Finalize) or not */
+            int32_t state = ompi_mpi_state;
+            if (state >= OMPI_MPI_STATE_INIT_COMPLETED &&
+                state < OMPI_MPI_STATE_FINALIZE_PAST_COMM_SELF_DESTRUCT) {
+               return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
+                                              FUNC_NAME);
+            } else {
+                /* We have no MPI object here so call ompi_errhandle_invoke
+                 * directly */
+                return ompi_errhandler_invoke(NULL, NULL, -1,
+                                              ompi_errcode_get_mpi_code(MPI_ERR_ARG),
+                                              FUNC_NAME);
+            }
         }
     }
 
