Skip to content

Commit 6c33fab

Browse files
committed
c interfaces: put back in the
TODO:BIGCOUNT comments to indicate where changes need to be made once issues #13153 and #13151 are resolved Signed-off-by: Howard Pritchard <howardp@lanl.gov>
1 parent 7cd9261 commit 6c33fab

13 files changed

+73
-0
lines changed

ompi/mpi/c/type_contiguous.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
40+
3541
PROTOTYPE ERROR_CLASS type_contiguous(COUNT count,
3642
DATATYPE oldtype,
3743
DATATYPE_OUT newtype)

ompi/mpi/c/type_create_darray.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@
3333
#include "ompi/datatype/ompi_datatype.h"
3434
#include "ompi/memchecker.h"
3535

36+
/*
37+
* TODO:BIGCOUNT this file will need to be updated once
38+
* the datatype framework supports bigcount
39+
*/
40+
41+
3642
PROTOTYPE ERROR_CLASS type_create_darray(INT size,
3743
INT rank,
3844
INT ndims,

ompi/mpi/c/type_create_hindexed.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@
3333
#include "ompi/memchecker.h"
3434

3535

36+
/*
37+
* TODO:BIGCOUNT this file will need to be updated once
38+
* the datatype framework supports bigcount
39+
*/
40+
41+
3642
PROTOTYPE ERROR_CLASS type_create_hindexed(COUNT count,
3743
COUNT_ARRAY array_of_blocklengths,
3844
AINT_COUNT_ARRAY array_of_displacements,

ompi/mpi/c/type_create_hindexed_block.c.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@
2525
#include "ompi/datatype/ompi_datatype.h"
2626
#include "ompi/memchecker.h"
2727

28+
/*
29+
* TODO:BIGCOUNT this file will need to be updated once
30+
* the datatype framework supports bigcount
31+
*/
32+
2833
PROTOTYPE ERROR_CLASS type_create_hindexed_block(COUNT count,
2934
COUNT blocklength,
3035
AINT_COUNT_ARRAY array_of_displacements,

ompi/mpi/c/type_create_hvector.c.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
3540
PROTOTYPE ERROR_CLASS type_create_hvector(COUNT count,
3641
COUNT blocklength,
3742
AINT_COUNT stride,

ompi/mpi/c/type_create_indexed_block.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
40+
3541
PROTOTYPE ERROR_CLASS type_create_indexed_block(COUNT count,
3642
COUNT blocklength,
3743
COUNT_ARRAY array_of_displacements,

ompi/mpi/c/type_create_struct.c.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
3540
PROTOTYPE ERROR_CLASS type_create_struct(COUNT count,
3641
COUNT_ARRAY array_of_blocklengths,
3742
AINT_COUNT_ARRAY array_of_displacements,

ompi/mpi/c/type_create_subarray.c.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@
3333
#include "ompi/datatype/ompi_datatype.h"
3434
#include "ompi/memchecker.h"
3535

36+
/*
37+
* TODO:BIGCOUNT this file will need to be updated once
38+
* the datatype framework supports bigcount
39+
*/
40+
3641
PROTOTYPE ERROR_CLASS type_create_subarray(INT ndims,
3742
COUNT_ARRAY size_array,
3843
COUNT_ARRAY subsize_array,

ompi/mpi/c/type_indexed.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
40+
3541
PROTOTYPE ERROR_CLASS type_indexed(COUNT count,
3642
COUNT_ARRAY array_of_blocklengths,
3743
COUNT_ARRAY array_of_displacements,

ompi/mpi/c/type_vector.c.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@
3232
#include "ompi/datatype/ompi_datatype.h"
3333
#include "ompi/memchecker.h"
3434

35+
/*
36+
* TODO:BIGCOUNT this file will need to be updated once
37+
* the datatype framework supports bigcount
38+
*/
39+
3540
PROTOTYPE ERROR_CLASS type_vector(COUNT count,
3641
COUNT blocklength,
3742
COUNT stride,

ompi/mpi/c/win_allocate.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ PROTOTYPE ERROR_CLASS win_allocate(AINT size, DISP disp_unit, INFO info,
6767
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COMM, FUNC_NAME);
6868
}
6969

70+
/*
71+
* TODO:BIGCOUNT remove this check once ompi-rma supports bigcount
72+
*/
7073
#if OMPI_BIGCOUNT_SRC
7174
OMPI_CHECK_MPI_COUNT_INT_CONVERSION_OVERFLOW(ret, disp_unit);
7275
if (OMPI_SUCCESS != ret) {
@@ -76,6 +79,9 @@ PROTOTYPE ERROR_CLASS win_allocate(AINT size, DISP disp_unit, INFO info,
7679
#endif
7780

7881
/* create window and return */
82+
/*
83+
* TODO:BIGCOUNT remove (int) before disp_unit once ompi-rma supports bigcount
84+
*/
7985
ret = ompi_win_allocate((size_t)size, (int)disp_unit, &(info->super),
8086
comm, baseptr, win);
8187
if (OMPI_SUCCESS != ret) {

ompi/mpi/c/win_allocate_shared.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ PROTOTYPE ERROR_CLASS win_allocate_shared(AINT size, DISP disp_unit, INFO info,
6161
} else if ( size < 0 ) {
6262
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_SIZE, FUNC_NAME);
6363
}
64+
/*
65+
* TODO:BIGCOUNT remove this check once ompi-rma supports bigcount
66+
*/
6467
#if OMPI_BIGCOUNT_SRC
6568
OMPI_CHECK_MPI_COUNT_INT_CONVERSION_OVERFLOW(ret, disp_unit);
6669
if (OMPI_SUCCESS != ret) {
@@ -76,6 +79,9 @@ PROTOTYPE ERROR_CLASS win_allocate_shared(AINT size, DISP disp_unit, INFO info,
7679
}
7780

7881
/* create window and return */
82+
/*
83+
* TODO:BIGCOUNT remove (int) from disp_unit once ompi-rma supports bigcount
84+
*/
7985
ret = ompi_win_allocate_shared((size_t)size, (int)disp_unit, &(info->super),
8086
comm, baseptr, win);
8187
if (OMPI_SUCCESS != ret) {

ompi/mpi/c/win_create.c.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ PROTOTYPE ERROR_CLASS win_create(BUFFER_OUT base, AINT size, DISP disp_unit,
6060
} else if ( disp_unit <= 0 ) {
6161
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_DISP, FUNC_NAME);
6262
}
63+
/*
64+
* TODO:BIGCOUNT remove this check once ompi-rma supports bigcount
65+
*/
6366
#if OMPI_BIGCOUNT_SRC
6467
OMPI_CHECK_MPI_COUNT_INT_CONVERSION_OVERFLOW(ret, disp_unit);
6568
if (OMPI_SUCCESS != ret) {
@@ -74,6 +77,9 @@ PROTOTYPE ERROR_CLASS win_create(BUFFER_OUT base, AINT size, DISP disp_unit,
7477
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COMM, FUNC_NAME);
7578
}
7679

80+
/*
81+
* TODO:BIGCOUNT remove (int) before disp_unit once ompi-rma supports bigcount
82+
*/
7783
/* create window and return */
7884
ret = ompi_win_create(base, (size_t)size, (int)disp_unit, comm,
7985
&(info->super), win);

0 commit comments

Comments
 (0)