Fix potential oob read in mca_coll_han_query_module_from_mca

devreal · devreal · commit 6b2887955f2b · 2022-10-21T10:41:46.000-04:00
Reported as CID 1516096.

Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/ompi/mca/coll/han/coll_han_component.c b/ompi/mca/coll/han/coll_han_component.c
@@ -187,9 +187,8 @@ mca_coll_han_query_module_from_mca(mca_base_component_t* c,
 {
     char *module_name, *endptr = NULL;
 
-    int mod_id = COMPONENTS_COUNT;
+    int mod_id = COMPONENTS_COUNT-1;
     mod_id = (*module_id > (uint32_t)mod_id) ? mod_id : (int)*module_id; /* stay in range */
-    mod_id = (mod_id < 0) ? 0 : mod_id;  /* in range */
 
     *storage = available_components[mod_id].component_name;
 

Original file line number	Diff line number	Diff line change
`@@ -187,9 +187,8 @@ mca_coll_han_query_module_from_mca(mca_base_component_t* c,`
`187`	`187`	`{`
`188`	`188`	`char module_name, endptr = NULL;`
`189`	`189`
`190`		`- int mod_id = COMPONENTS_COUNT;`
	`190`	`+ int mod_id = COMPONENTS_COUNT-1;`
`191`	`191`	`mod_id = (module_id > (uint32_t)mod_id) ? mod_id : (int)module_id; /* stay in range */`
`192`		`- mod_id = (mod_id < 0) ? 0 : mod_id; /* in range */`
`193`	`192`
`194`	`193`	`*storage = available_components[mod_id].component_name;`
`195`	`194`