Skip to content

Commit 677ce0a

Browse files
committed
Update PMIx configure logic in the embedded component
PMIx is removing the --enable-embedded-libevent and --enable-embedded-hwloc flags as they are confusing users. Instead, we will use the --enable-embedded-mode to handle both of these options. Update the embedded configury to handle it. Signed-off-by: Ralph Castain <rhc@pmix.org>
1 parent 5aef314 commit 677ce0a

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

opal/mca/pmix/pmix4x/configure.m4

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ AC_DEFUN([MCA_opal_pmix_pmix4x_CONFIG],[
3737
opal_pmix_pmix4x_save_LDFLAGS=$LDFLAGS
3838
opal_pmix_pmix4x_save_LIBS=$LIBS
3939

40-
AC_ARG_ENABLE([install-libpmix],
41-
[AC_HELP_STRING([--enable-install-libpmix],
42-
[Enable a native PMIx library and headers in the OMPI install location (default: disabled)])])
43-
4440
AC_ARG_ENABLE([pmix-timing],
4541
[AC_HELP_STRING([--enable-pmix-timing],
4642
[Enable PMIx timing measurements (default: disabled)])])
@@ -53,17 +49,12 @@ AC_DEFUN([MCA_opal_pmix_pmix4x_CONFIG],[
5349
opal_pmix_pmix4x_timing_flag=--disable-pmix-timing
5450
fi
5551

56-
opal_pmix_pmix4x_args="$opal_pmix_pmix4x_timing_flag --without-tests-examples --disable-pmix-binaries --disable-pmix-backward-compatibility --disable-visibility --enable-embedded-libevent --with-libevent-header=\\\"opal/mca/event/$opal_event_base_include\\\" --enable-embedded-hwloc --with-hwloc-header=\\\"$opal_hwloc_base_include\\\""
52+
opal_pmix_pmix4x_args="$opal_pmix_pmix4x_timing_flag --without-tests-examples --with-pmix-symbol-rename=OPAL_MCA_PMIX4X_ --disable-pmix-binaries --disable-pmix-backward-compatibility --disable-visibility --enable-embedded-mode --with-libevent-header=\\\"opal/mca/event/$opal_event_base_include\\\" --with-hwloc-header=\\\"$opal_hwloc_base_include\\\""
5753
AS_IF([test "$enable_debug" = "yes"],
5854
[opal_pmix_pmix4x_args="--enable-debug $opal_pmix_pmix4x_args"
5955
CFLAGS="$OPAL_CFLAGS_BEFORE_PICKY $OPAL_VISIBILITY_CFLAGS -g"],
6056
[opal_pmix_pmix4x_args="--disable-debug $opal_pmix_pmix4x_args"
6157
CFLAGS="$OPAL_CFLAGS_BEFORE_PICKY $OPAL_VISIBILITY_CFLAGS"])
62-
AC_MSG_CHECKING([if want to install standalone libpmix])
63-
AS_IF([test "$enable_install_libpmix" = "yes"],
64-
[AC_MSG_RESULT([yes])],
65-
[AC_MSG_RESULT([no])
66-
opal_pmix_pmix4x_args="--with-pmix-symbol-rename=OPAL_MCA_PMIX4X_ --enable-embedded-mode $opal_pmix_pmix4x_args"])
6758
AS_IF([test "$with_devel_headers" = "yes"],
6859
[opal_pmix_pmix4x_args="--with-devel-headers $opal_pmix_pmix4x_args"])
6960
CPPFLAGS="-I$OPAL_TOP_SRCDIR -I$OPAL_TOP_BUILDDIR -I$OPAL_TOP_SRCDIR/opal/include -I$OPAL_TOP_BUILDDIR/opal/include $CPPFLAGS"

opal/mca/pmix/pmix4x/pmix/config/pmix_setup_hwloc.m4

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@ AC_DEFUN([PMIX_HWLOC_CONFIG],[
1717
[AC_HELP_STRING([--with-hwloc-header=HEADER],
1818
[The value that should be included in C files to include hwloc.h])])
1919

20-
AC_ARG_ENABLE([embedded-hwloc],
21-
[AC_HELP_STRING([--enable-embedded-hwloc],
22-
[Enable use of locally embedded hwloc])])
23-
24-
AS_IF([test "$enable_embedded_hwloc" = "yes"],
20+
AS_IF([test "$pmix_mode" = "embedded"],
2521
[_PMIX_HWLOC_EMBEDDED_MODE],
2622
[_PMIX_HWLOC_EXTERNAL])
2723

opal/mca/pmix/pmix4x/pmix/config/pmix_setup_libevent.m4

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@ AC_DEFUN([PMIX_LIBEVENT_CONFIG],[
1919
[AC_HELP_STRING([--with-libevent-header=HEADER],
2020
[The value that should be included in C files to include event.h])])
2121

22-
AC_ARG_ENABLE([embedded-libevent],
23-
[AC_HELP_STRING([--enable-embedded-libevent],
24-
[Enable use of locally embedded libevent])])
25-
26-
AS_IF([test "$enable_embedded_libevent" = "yes"],
22+
AS_IF([test "$pmix_mode" = "embedded"],
2723
[_PMIX_LIBEVENT_EMBEDDED_MODE],
2824
[_PMIX_LIBEVENT_EXTERNAL])
2925

0 commit comments

Comments
 (0)