Skip to content

Commit 623f514

Browse files
committed
ompi/tools/wrappers/ompi_wrapper_script.in: add missing variable name prefixes
When open-mpi is compiled with script wrapper compilers option: ./configure --enable-script-wrapper-compilers ... The generated wrappers emit warnings: Use of uninitialized value $cppflags in substitution (s///) at ./mpicc line 67. Use of uninitialized value $cflags in substitution (s///) at ./mpicc line 68. Use of uninitialized value $cflags_prefix in substitution (s///) at ./mpicc line 69. Use of uninitialized value $cxxflags in substitution (s///) at ./mpicc line 70. Use of uninitialized value $cxxflags_prefix in substitution (s///) at ./mpicc line 71. Use of uninitialized value $fcflags in substitution (s///) at ./mpicc line 72. Use of uninitialized value $fcflags_prefix in substitution (s///) at ./mpicc line 73. Use of uninitialized value $ldflags in substitution (s///) at ./mpicc line 74. Use of uninitialized value $ldflags_static in substitution (s///) at ./mpicc line 75. Use of uninitialized value $fc_ldflags in substitution (s///) at ./mpicc line 78. Use of uninitialized value $fc_ldflags_static in substitution (s///) at ./mpicc line 79. Use of uninitialized value $fc_libs in substitution (s///) at ./mpicc line 80. Use of uninitialized value $fc_libs_static in substitution (s///) at ./mpicc line 81. Commit 1f18b20 "wrappers: Improve static library handling" introduced new global variables prefixed with "wrapper_". A block of code to fixup directories is using variables without the prefix in their names. This commit fixes this issue by correctly naming the variables. Signed-off-by: Julien Olivain <ju.o@free.fr>
1 parent 541afb6 commit 623f514

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

ompi/tools/wrappers/ompi_wrapper_script.in

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -64,21 +64,21 @@ my $libs = "";
6464
my $libs_static = "";
6565

6666
# run flags through regex to fix directories...
67-
$cppflags =~ s/\$\{includedir\}/$includedir/g;
68-
$cflags =~ s/\$\{includedir\}/$includedir/g;
69-
$cflags_prefix =~ s/\$\{includedir\}/$includedir/g;
70-
$cxxflags =~ s/\$\{includedir\}/$includedir/g;
71-
$cxxflags_prefix =~ s/\$\{includedir\}/$includedir/g;
72-
$fcflags =~ s/\$\{includedir\}/$includedir/g;
73-
$fcflags_prefix =~ s/\$\{includedir\}/$includedir/g;
74-
$ldflags =~ s/\$\{libdir\}/$libdir/g;
75-
$ldflags_static =~ s/\$\{libdir\}/$libdir/g;
76-
$libs =~ s/\$\{libdir\}/$libdir/g;
77-
$libs_static =~ s/\$\{libdir\}/$libdir/g;
78-
$fc_ldflags =~ s/\$\{libdir\}/$libdir/g;
79-
$fc_ldflags_static =~ s/\$\{libdir\}/$libdir/g;
80-
$fc_libs =~ s/\$\{libdir\}/$libdir/g;
81-
$fc_libs_static =~ s/\$\{libdir\}/$libdir/g;
67+
$wrapper_cppflags =~ s/\$\{includedir\}/$includedir/g;
68+
$wrapper_cflags =~ s/\$\{includedir\}/$includedir/g;
69+
$wrapper_cflags_prefix =~ s/\$\{includedir\}/$includedir/g;
70+
$wrapper_cxxflags =~ s/\$\{includedir\}/$includedir/g;
71+
$wrapper_cxxflags_prefix =~ s/\$\{includedir\}/$includedir/g;
72+
$wrapper_fcflags =~ s/\$\{includedir\}/$includedir/g;
73+
$wrapper_fcflags_prefix =~ s/\$\{includedir\}/$includedir/g;
74+
$wrapper_ldflags =~ s/\$\{libdir\}/$libdir/g;
75+
$wrapper_ldflags_static =~ s/\$\{libdir\}/$libdir/g;
76+
$wrapper_libs =~ s/\$\{libdir\}/$libdir/g;
77+
$wrapper_libs_static =~ s/\$\{libdir\}/$libdir/g;
78+
$wrapper_fc_ldflags =~ s/\$\{libdir\}/$libdir/g;
79+
$wrapper_fc_ldflags_static =~ s/\$\{libdir\}/$libdir/g;
80+
$wrapper_fc_libs =~ s/\$\{libdir\}/$libdir/g;
81+
$wrapper_fc_libs_static =~ s/\$\{libdir\}/$libdir/g;
8282

8383
sub check_env {
8484
my $envvar = shift;

0 commit comments

Comments
 (0)