Skip to content

Commit 610d408

Browse files
authored
Merge pull request #10899 from karasevb/ucx_vers_warn
ucx/pml: show warning if already unsupported UCX version is used
2 parents 6c90ecc + 8362a2d commit 610d408

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

config/ompi_check_ucx.m4

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,15 @@ AC_DEFUN([OMPI_CHECK_UCX],[
7474
[ompi_check_ucx_cv_have_version_1_8=yes])])
7575
AS_IF([test "${ompi_check_ucx_cv_have_version_1_8}" = "yes"],
7676
[AC_MSG_WARN([UCX support skipped because version 1.8.x was found, which has a known catastrophic issue.])
77-
AC_MSG_WARN([Please upgrade to UCX version 1.9 or higher.])
7877
ompi_check_ucx_happy=no])])
78+
AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
79+
#include <ucp/api/ucp_version.h>
80+
]], [[
81+
#if (UCP_API_MAJOR < 1) || ((UCP_API_MAJOR == 1) && (UCP_API_MINOR < 9))
82+
#error "Version too low"
83+
#endif
84+
]])],
85+
[], [AC_MSG_WARN([UCX version is too old, please upgrade to 1.9 or higher.])])
7986

8087
AS_IF([test "$ompi_check_ucx_happy" = yes],
8188
[AC_CHECK_DECLS([ucp_tag_send_nbr],

ompi/mca/pml/ucx/pml_ucx.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,12 @@ int mca_pml_ucx_open(void)
214214
return OMPI_ERROR;
215215
}
216216

217+
if ((major_version == 1) && (minor_version < 9)) {
218+
/* show warning due to issue #8549 */
219+
PML_UCX_WARN("UCX version %u.%u.%u is too old, please install 1.9.x or "
220+
"newer", major_version, minor_version, release_number);
221+
}
222+
217223
/* Read options */
218224
status = ucp_config_read("MPI", NULL, &config);
219225
if (UCS_OK != status) {

0 commit comments

Comments
 (0)