Skip to content

Commit 6043ac5

Browse files
committed
fcoll/vulcan: cleanup write_all operations
This is a cleanup of the write_all operation, in preparation for adding read_all implementation to the vulcan component. Specifically: - remove the multiple group option: this was envisioned for the vulcan component, but never fully implemented. Therefore, having a few stubs at some locations (and an mca parameter) doesn't make sense, and are being removed to simplify the code. - remote the write_chunksize option: this was an artifact of the code based having evolved from dynamic_gen2 (where the option makes sense). However, in vulcan it doesn't really make sense and was actually not correctly implemented eitherway, so if somebody would have used that option, it would prbably have failed. The changed have been validated with the ompio testsuite as well as the hdf5 testphdf5, t_shapesame, and t_filters_parallel tests. Signed-off-by: Edgar Gabriel <edgar.gabriel@amd.com>
1 parent afc970c commit 6043ac5

File tree

3 files changed

+46
-198
lines changed

3 files changed

+46
-198
lines changed

ompi/mca/fcoll/vulcan/fcoll_vulcan.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ BEGIN_C_DECLS
4040
/* Globally exported variables */
4141

4242
extern int mca_fcoll_vulcan_priority;
43-
extern int mca_fcoll_vulcan_num_groups;
44-
extern int mca_fcoll_vulcan_write_chunksize;
4543
extern int mca_fcoll_vulcan_async_io;
4644
extern int mca_fcoll_vulcan_use_accelerator_buffers;
4745

ompi/mca/fcoll/vulcan/fcoll_vulcan_component.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ const char *mca_fcoll_vulcan_component_version_string =
4343
* Global variables
4444
*/
4545
int mca_fcoll_vulcan_priority = 10;
46-
int mca_fcoll_vulcan_num_groups = 1;
47-
int mca_fcoll_vulcan_write_chunksize = -1;
4846
int mca_fcoll_vulcan_async_io = 0;
4947

5048
/*
@@ -91,20 +89,6 @@ vulcan_register(void)
9189
OPAL_INFO_LVL_9,
9290
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_priority);
9391

94-
mca_fcoll_vulcan_num_groups = 1;
95-
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
96-
"num_groups", "Number of subgroups created by the vulcan component",
97-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
98-
OPAL_INFO_LVL_9,
99-
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_num_groups);
100-
101-
mca_fcoll_vulcan_write_chunksize = -1;
102-
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
103-
"write_chunksize", "Chunk size written at once. Default: stripe_size of the file system",
104-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
105-
OPAL_INFO_LVL_9,
106-
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_write_chunksize);
107-
10892
mca_fcoll_vulcan_async_io = 0;
10993
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
11094
"async_io", "Asynchronous I/O support options. 0: Automatic choice (default) "

0 commit comments

Comments
 (0)