Skip to content

Commit 4a55864

Browse files
committed
config: fix --enable-mca-dso: correct the AS_VAR macro
Fix bug introduced in 000f7e8. AS_VAR_COPY(dest, source) interprets the 'source' argument as a variable name. So, before this patch, the value was not '1', but '$1', which evaluated to garbage and broke the --enable-mca-dso argument. Signed-off-by: Alexei Colin <acolin@isi.edu>
1 parent b33b294 commit 4a55864

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

config/opal_mca.m4

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ AC_DEFUN([OPAL_MCA],[
103103
type=$item
104104
fi
105105
if test -z $comp ; then
106-
AS_VAR_COPY([AS_TR_SH([DISABLE_$type])], [1])
106+
AS_VAR_SET([AS_TR_SH([DISABLE_$type])], [1])
107107
msg="$item $msg"
108108
else
109-
AS_VAR_COPY([AS_TR_SH([DISABLE_$type_$comp])], [1])
109+
AS_VAR_SET([AS_TR_SH([DISABLE_$type_$comp])], [1])
110110
msg="$item $msg"
111111
fi
112112
done
@@ -149,7 +149,7 @@ AC_DEFUN([OPAL_MCA],[
149149
AC_MSG_ERROR([*** The enable-mca-direct flag requires a
150150
*** list of type-component pairs. Invalid input detected.])
151151
else
152-
AS_VAR_COPY([AS_TR_SH([DIRECT_$type])], [AS_TR_SH([$comp])])
152+
AS_VAR_SET([AS_TR_SH([DIRECT_$type])], [AS_TR_SH([$comp])])
153153
msg="$item $msg"
154154
fi
155155
done
@@ -184,7 +184,7 @@ AC_DEFUN([OPAL_MCA],[
184184
IFS="${IFS}$PATH_SEPARATOR,"
185185
msg=
186186
for item in $enable_mca_dso; do
187-
AS_VAR_COPY([AS_TR_SH([DSO_$item])], [1])
187+
AS_VAR_SET([AS_TR_SH([DSO_$item])], [1])
188188
msg="$item $msg"
189189
done
190190
IFS="$ifs_save"
@@ -212,7 +212,7 @@ AC_DEFUN([OPAL_MCA],[
212212
IFS="${IFS}$PATH_SEPARATOR,"
213213
msg=
214214
for item in $enable_mca_static; do
215-
AS_VAR_COPY([AS_TR_SH([STATIC_$item])], [1])
215+
AS_VAR_SET([AS_TR_SH([STATIC_$item])], [1])
216216
msg="$item $msg"
217217
done
218218
IFS="$ifs_save"

0 commit comments

Comments
 (0)