Fix resource leak reported by coverity scan report CID 1515756

cniethammer · cniethammer · commit 4691a4b72332 · 2022-10-18T12:11:09.000+02:00
Free env_str after use by opal_setenv. The opal_setenv function will copy
the value as does the original setenv.

Signed-off-by: Christoph Niethammer &lt;niethammer@hlrs.de&gt;
diff --git a/ompi/tools/mpirun/main.c b/ompi/tools/mpirun/main.c
@@ -110,6 +110,7 @@ static void setup_mca_prefixes(void)
     char *env_str = opal_argv_join(tmp, ',');
     opal_setenv("OMPI_MCA_PREFIXES", env_str, true,
                 &environ);
+    free(env_str);
 
     opal_argv_free(tmp);
 }

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,7 @@ static void setup_mca_prefixes(void)`
`110`	`110`	`char *env_str = opal_argv_join(tmp, ',');`
`111`	`111`	`opal_setenv("OMPI_MCA_PREFIXES", env_str, true,`
`112`	`112`	`&environ);`
	`113`	`+ free(env_str);`
`113`	`114`
`114`	`115`	`opal_argv_free(tmp);`
`115`	`116`	`}`