Skip to content

Commit 4358e75

Browse files
authored
Merge pull request #7866 from tkordenbrock/topic/master/portals4.fix-inappropriate-use-of-abort
portals4: fix inappropriate use of abort() in mtl-portals4 and coll-portals4 components
2 parents 868eee3 + 04b9463 commit 4358e75

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ompi/mca/coll/portals4/coll_portals4_component.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ portals4_progress(void)
761761
}
762762
else if (PTL_EQ_DROPPED == ret) {
763763
opal_output(ompi_coll_base_framework.framework_output, "Flow control situation without recovery (EQ_DROPPED)\n");
764-
abort();
764+
ompi_rte_abort(ret, "coll-portals4: Flow control situation without recovery (EQ_DROPPED)");
765765
}
766766
else {
767767
opal_output(ompi_coll_base_framework.framework_output, "Error returned from PtlEQGet: %d", ret);

ompi/mca/mtl/portals4/mtl_portals4_component.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ ompi_mtl_portals4_progress(void)
523523
if (OMPI_SUCCESS != ret) {
524524
opal_output(ompi_mtl_base_framework.framework_output,
525525
"Error returned from target event callback: %d", ret);
526-
abort();
526+
ompi_rte_abort(ret, "mtl-portals4: Error returned from target event callback");
527527
}
528528
}
529529
break;
@@ -535,7 +535,7 @@ ompi_mtl_portals4_progress(void)
535535
if (OMPI_SUCCESS != ret) {
536536
opal_output(ompi_mtl_base_framework.framework_output,
537537
"Error returned from target event callback: %d", ret);
538-
abort();
538+
ompi_rte_abort(ret, "mtl-portals4: Error returned from target event callback");
539539
}
540540
}
541541
break;
@@ -550,12 +550,12 @@ ompi_mtl_portals4_progress(void)
550550
opal_output_verbose(1, ompi_mtl_base_framework.framework_output,
551551
"%s:%d: flowctl_trigger() failed: %d\n",
552552
__FILE__, __LINE__, ret);
553-
abort();
553+
ompi_rte_abort(ret, "mtl-portals4: Flow control failed (PT_DISABLED)");
554554
}
555555
#else
556556
opal_output(ompi_mtl_base_framework.framework_output,
557557
"Flow control situation without recovery (PT_DISABLED)");
558-
abort();
558+
ompi_rte_abort(ret, "mtl-portals4: Flow control situation without recovery (PT_DISABLED)");
559559
#endif
560560
break;
561561

@@ -573,7 +573,7 @@ ompi_mtl_portals4_progress(void)
573573
opal_output(ompi_mtl_base_framework.framework_output,
574574
"Flow control situation without recovery (EQ_DROPPED): %d",
575575
which);
576-
abort();
576+
ompi_rte_abort(ret, "mtl-portals4: Flow control situation without recovery (EQ_DROPPED)");
577577
} else {
578578
opal_output(ompi_mtl_base_framework.framework_output,
579579
"Error returned from PtlEQGet: %d", ret);

0 commit comments

Comments
 (0)