Skip to content

Commit 3dd091e

Browse files
committed
Always build MPI1 compat functions
This patch is similar to 4aa91e1, applied to v4.x, to re-enable building the removed MPI-1 functions and maintain C/mpi-f.h ABI compliance from 3.0.0 through master. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
1 parent b934c90 commit 3dd091e

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

ompi/include/mpi.h.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3043,7 +3043,7 @@ OMPI_DECLSPEC int OMPI_C_MPI_NULL_DELETE_FN( MPI_Comm comm, int comm_keyval,
30433043
void* extra_state )
30443044
__mpi_interface_deprecated__("MPI_NULL_DELETE_FN was deprecated in MPI-2.0; use MPI_COMM_NULL_DELETE_FN instead.");
30453045

3046-
#if !OMPI_OMIT_MPI1_COMPAT_DECLS
3046+
#if (!OMPI_OMIT_MPI1_COMPAT_DECLS || OMPI_BUILDING)
30473047
/*
30483048
* Removed typedefs. These typedefs are only available if Open MPI
30493049
* was configured with --enable-mpi1-compatibility.

ompi/mpi/c/Makefile.am

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,10 @@ interface_profile_sources = \
484484
win_unlock_all.c \
485485
win_wait.c
486486

487-
if OMPI_ENABLE_MPI1_COMPAT
487+
# The following functions were removed from the MPI standard, but are
488+
# retained for ABI compliance reasons. They are listed independently
489+
# of the other MPI functions in case we one day change behavior around
490+
# ABI compliance.
488491
interface_profile_sources += \
489492
address.c \
490493
errhandler_create.c \
@@ -496,7 +499,6 @@ interface_profile_sources += \
496499
type_lb.c \
497500
type_struct.c \
498501
type_ub.c
499-
endif
500502

501503
libmpi_c_profile_la_SOURCES = $(interface_profile_sources)
502504
libmpi_c_profile_la_CPPFLAGS = -DOMPI_BUILD_MPI_PROFILING=1

ompi/mpi/fortran/mpif-h/Makefile.am

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,10 @@ lib@OMPI_LIBMPI_NAME@_mpifh_la_SOURCES += \
531531
win_flush_local_f.c \
532532
win_flush_local_all_f.c
533533

534-
535-
if OMPI_ENABLE_MPI1_COMPAT
534+
# The following functions were removed from the MPI standard, but are
535+
# retained for ABI compliance reasons. They are listed independently
536+
# of the other MPI functions in case we one day change behavior around
537+
# ABI compliance.
536538
lib@OMPI_LIBMPI_NAME@_mpifh_la_SOURCES += \
537539
address_f.c \
538540
errhandler_create_f.c \
@@ -545,7 +547,6 @@ lib@OMPI_LIBMPI_NAME@_mpifh_la_SOURCES += \
545547
type_struct_f.c \
546548
type_ub_f.c
547549
endif
548-
endif
549550

550551
#
551552
# Conditionally install the header files

ompi/mpi/fortran/mpif-h/profile/Makefile.am

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,10 @@ linked_files = \
443443
pwin_flush_local_f.c \
444444
pwin_flush_local_all_f.c
445445

446-
if OMPI_ENABLE_MPI1_COMPAT
446+
# The following functions were removed from the MPI standard, but are
447+
# retained for ABI compliance reasons. They are listed independently
448+
# of the other MPI functions in case we one day change behavior around
449+
# ABI compliance.
447450
linked_files += \
448451
paddress_f.c \
449452
perrhandler_create_f.c \
@@ -455,7 +458,6 @@ linked_files += \
455458
ptype_lb_f.c \
456459
ptype_struct_f.c \
457460
ptype_ub_f.c
458-
endif
459461

460462
#
461463
# Sym link in the sources from the real MPI directory

0 commit comments

Comments
 (0)