osc/rdma: Make sure the rank_array is initialized

devreal · devreal · commit 3c0ec476edc0 · 2021-10-29T21:50:03.000-04:00
A bug introduced in #7985 where a calloc call was replaced with an allocation that does not initialize the memory. Fixes #9590 Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
diff --git a/ompi/mca/osc/rdma/osc_rdma_component.c b/ompi/mca/osc/rdma/osc_rdma_component.c
@@ -491,6 +491,7 @@ static int allocate_state_single (ompi_osc_rdma_module_t *module, void **base, s
     if (OPAL_UNLIKELY(NULL == module->rank_array)) {
         return OMPI_ERR_OUT_OF_RESOURCE;
     }
+    memset(module->rank_array, 0, total_size);
 
     /* Note, the extra module->region_size space added after local_rank_array_size
      * is unused but is there to match what happens in allocte_state_shared()

Original file line number	Diff line number	Diff line change
`@@ -491,6 +491,7 @@ static int allocate_state_single (ompi_osc_rdma_module_t module, void *base, s`
`491`	`491`	`if (OPAL_UNLIKELY(NULL == module->rank_array)) {`
`492`	`492`	`return OMPI_ERR_OUT_OF_RESOURCE;`
`493`	`493`	`}`
	`494`	`+ memset(module->rank_array, 0, total_size);`
`494`	`495`
`495`	`496`	`/* Note, the extra module->region_size space added after local_rank_array_size`
`496`	`497`	`* is unused but is there to match what happens in allocte_state_shared()`