Skip to content

Commit 3b6fe68

Browse files
authored
Merge pull request #12281 from lrbison/minor_fixes
Minor fixes: comment correction and spelling "Registration"
2 parents 8eb82d3 + 0da5eec commit 3b6fe68

File tree

7 files changed

+10
-13
lines changed

7 files changed

+10
-13
lines changed

ompi/mca/coll/base/coll_base_util.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ OMPI_DECLSPEC OBJ_CLASS_DECLARATION(mca_coll_base_avail_coll_t);
111111

112112
/**
113113
* A MPI_like function doing a send and a receive simultaneously.
114-
* If one of the communications results in a zero-byte message the
115-
* communication is ignored, and no message will cross to the peer.
114+
* Posts a irecv, does a send, then gets irecv completion.
116115
*/
117116
int ompi_coll_base_sendrecv_actual( const void* sendbuf, size_t scount,
118117
ompi_datatype_t* sdatatype,
@@ -125,10 +124,8 @@ int ompi_coll_base_sendrecv_actual( const void* sendbuf, size_t scount,
125124

126125

127126
/**
128-
* Similar to the function above this implementation of send-receive
129-
* do not generate communications for zero-bytes messages. Thus, it is
130-
* improper to use in the context of some algorithms for collective
131-
* communications.
127+
* A wrapper around ompi_coll_base_sendrecv_actual, with an optimized
128+
* path for self-directed send/recv.
132129
*/
133130
static inline int
134131
ompi_coll_base_sendrecv( void* sendbuf, size_t scount, ompi_datatype_t* sdatatype,

ompi/mca/osc/rdma/osc_rdma_peer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ int ompi_osc_rdma_new_peer (struct ompi_osc_rdma_module_t *module, int peer_id,
145145
*
146146
* This function reads the registration handle and state pointer from the peer that holds that data. If necessary
147147
* it will then ready information about the peer from its state data structure. This information includes the
148-
* displacement unit, base pointer, window size, and registation handle (if applicable).
148+
* displacement unit, base pointer, window size, and registration handle (if applicable).
149149
*/
150150
static int ompi_osc_rdma_peer_setup (ompi_osc_rdma_module_t *module, ompi_osc_rdma_peer_t *peer)
151151
{

opal/mca/btl/sm/btl_sm_component.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ mca_btl_sm_component_init(int *num_btls, bool enable_progress_threads, bool enab
346346
mca_btl_sm.super.btl_max_send_size = mca_btl_sm.super.btl_eager_limit;
347347
mca_btl_sm.super.btl_min_rdma_pipeline_size = INT_MAX;
348348
}
349-
if (mca_smsc_base_has_feature(MCA_SMSC_FEATURE_REQUIRE_REGISTATION)) {
349+
if (mca_smsc_base_has_feature(MCA_SMSC_FEATURE_REQUIRE_REGISTRATION)) {
350350
ssize_t handle_size = mca_smsc_base_registration_data_size();
351351
if (handle_size > 0) {
352352
mca_btl_sm.super.btl_registration_handle_size = (size_t) handle_size;

opal/mca/rcache/base/rcache_base_vma_tree.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626
/**
2727
* @file
28-
* Registation cache VMA tree implementation
28+
* Registration cache VMA tree implementation
2929
*/
3030
#ifndef MCA_RCACHE_BASE_VMA_TREE_H
3131
#define MCA_RCACHE_BASE_VMA_TREE_H

opal/mca/rcache/rcache.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ enum {
3939
MCA_RCACHE_FLAGS_CACHE_BYPASS = 0x0001,
4040
/** persistent registration */
4141
MCA_RCACHE_FLAGS_PERSIST = 0x0002,
42-
/** registation requires strong ordering (disables relaxed ordering) */
42+
/** registration requires strong ordering (disables relaxed ordering) */
4343
MCA_RCACHE_FLAGS_SO_MEM = 0x0004,
4444
/** address range is accelerator buffer */
4545
MCA_RCACHE_FLAGS_ACCELERATOR_MEM = 0x0008,

opal/mca/smsc/knem/smsc_knem_module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ void mca_smsc_knem_unmap_peer_region(void *ctx)
146146

147147
mca_smsc_knem_module_t mca_smsc_knem_module = {
148148
.super = {
149-
.features = MCA_SMSC_FEATURE_REQUIRE_REGISTATION,
149+
.features = MCA_SMSC_FEATURE_REQUIRE_REGISTRATION,
150150
.registration_data_size = sizeof(mca_smsc_knem_registration_data_t),
151151
.get_endpoint = mca_smsc_knem_get_endpoint,
152152
.return_endpoint = mca_smsc_knem_return_endpoint,

opal/mca/smsc/smsc.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ enum {
133133
/** Module requires the local registration of any region that will be used for single-copy
134134
* operations. It is theresponsibility of the caller to pass this data with the pointer to the
135135
* peer. */
136-
MCA_SMSC_FEATURE_REQUIRE_REGISTATION = 1,
136+
MCA_SMSC_FEATURE_REQUIRE_REGISTRATION = 1,
137137
/** Module can map peer memory into the local processes' address space. */
138138
MCA_SMSC_FEATURE_CAN_MAP = 2,
139139
};
@@ -239,7 +239,7 @@ static inline bool mca_smsc_base_has_feature(uint64_t feature)
239239

240240
static inline ssize_t mca_smsc_base_registration_data_size(void)
241241
{
242-
if (NULL == mca_smsc || !mca_smsc_base_has_feature(MCA_SMSC_FEATURE_REQUIRE_REGISTATION)) {
242+
if (NULL == mca_smsc || !mca_smsc_base_has_feature(MCA_SMSC_FEATURE_REQUIRE_REGISTRATION)) {
243243
return OPAL_ERR_NOT_AVAILABLE;
244244
}
245245

0 commit comments

Comments
 (0)