UCX/WPOOL: fixed potential deadlock

Sergey Oblomov · Sergey Oblomov · commit 34f2f6af84a3 · 2020-06-27T15:19:01.000+03:00
- fixed potential deadlock in error processing

Signed-off-by: Sergey Oblomov &lt;sergeyo@mellanox.com&gt;
diff --git a/opal/mca/common/ucx/common_ucx_wpool.h b/opal/mca/common/ucx/common_ucx_wpool.h
@@ -470,7 +470,6 @@ opal_common_ucx_wpmem_cmpswp_nb(opal_common_ucx_wpmem_t *mem, uint64_t compare,
     rc = _periodical_flush_nb(mem, winfo, target);
     if(OPAL_UNLIKELY(OPAL_SUCCESS != rc)){
         MCA_COMMON_UCX_VERBOSE(1, "_incr_and_check_inflight_ops failed: %d", rc);
-        return rc;
     }
 
     opal_mutex_unlock(&winfo->mutex);

Original file line number	Diff line number	Diff line change
`@@ -470,7 +470,6 @@ opal_common_ucx_wpmem_cmpswp_nb(opal_common_ucx_wpmem_t *mem, uint64_t compare,`
`470`	`470`	`rc = _periodical_flush_nb(mem, winfo, target);`
`471`	`471`	`if(OPAL_UNLIKELY(OPAL_SUCCESS != rc)){`
`472`	`472`	`MCA_COMMON_UCX_VERBOSE(1, "_incr_and_check_inflight_ops failed: %d", rc);`
`473`		`- return rc;`
`474`	`473`	`}`
`475`	`474`
`476`	`475`	`opal_mutex_unlock(&winfo->mutex);`