Skip to content

Commit 2f63e23

Browse files
committed
Remove the SM collective component
It has been pointed out that the SM component was turned off for a very long time, so it was not used and not tested. Moreover, when enabled the performance are below tuned, so there is no reason to keep it around. The good news is that there are two possible replacement that are up to review and merge (ACOL and XHC), so at the developers meeting in Austin 2024 we decided to remove the SM collective component. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
1 parent 6564419 commit 2f63e23

26 files changed

+13
-2959
lines changed

ompi/mca/coll/han/coll_han_component.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ const char *mca_coll_han_component_version_string =
3737
"Open MPI HAN collective MCA component version " OMPI_VERSION;
3838

3939
ompi_coll_han_components ompi_coll_han_available_components[COMPONENTS_COUNT] = {
40-
{ SELF, "self", NULL },
41-
{ BASIC, "basic", NULL },
42-
{ LIBNBC, "libnbc", NULL },
43-
{ TUNED, "tuned", NULL },
44-
{ SM, "sm", NULL },
45-
{ ADAPT, "adapt", NULL },
46-
{ HAN, "han", NULL }
40+
{ SELF, "self" },
41+
{ BASIC, "basic" },
42+
{ LIBNBC, "libnbc" },
43+
{ TUNED, "tuned" },
44+
{ SM, "sm" }, /* this should not be used, the collective component is gone */
45+
{ ADAPT, "adapt" },
46+
{ HAN, "han" }
4747
};
4848

4949
/*
@@ -287,7 +287,7 @@ static int han_register(void)
287287

288288
cs->han_bcast_low_module = 0;
289289
(void) mca_coll_han_query_module_from_mca(c, "bcast_low_module",
290-
"low level module for bcast, 0 tuned, 1 sm",
290+
"low level module for bcast, currently only 0 for tuned",
291291
OPAL_INFO_LVL_9,
292292
&cs->han_bcast_low_module,
293293
&cs->han_op_module_name.bcast.han_op_low_module_name);
@@ -307,7 +307,7 @@ static int han_register(void)
307307

308308
cs->han_reduce_low_module = 0;
309309
(void) mca_coll_han_query_module_from_mca(c, "reduce_low_module",
310-
"low level module for allreduce, 0 tuned, 1 sm",
310+
"low level module for allreduce, currently only 0 tuned",
311311
OPAL_INFO_LVL_9, &cs->han_reduce_low_module,
312312
&cs->han_op_module_name.reduce.han_op_low_module_name);
313313

@@ -326,7 +326,7 @@ static int han_register(void)
326326

327327
cs->han_allreduce_low_module = 0;
328328
(void) mca_coll_han_query_module_from_mca(c, "allreduce_low_module",
329-
"low level module for allreduce, 0 tuned, 1 sm",
329+
"low level module for allreduce, currently only 0 tuned",
330330
OPAL_INFO_LVL_9, &cs->han_allreduce_low_module,
331331
&cs->han_op_module_name.allreduce.han_op_low_module_name);
332332

@@ -338,7 +338,7 @@ static int han_register(void)
338338

339339
cs->han_allgather_low_module = 0;
340340
(void) mca_coll_han_query_module_from_mca(c, "allgather_low_module",
341-
"low level module for allgather, 0 tuned, 1 sm",
341+
"low level module for allgather, currently only 0 tuned",
342342
OPAL_INFO_LVL_9, &cs->han_allgather_low_module,
343343
&cs->han_op_module_name.allgather.han_op_low_module_name);
344344

@@ -350,7 +350,7 @@ static int han_register(void)
350350

351351
cs->han_gather_low_module = 0;
352352
(void) mca_coll_han_query_module_from_mca(c, "gather_low_module",
353-
"low level module for gather, 0 tuned, 1 sm",
353+
"low level module for gather, currently only 0 tuned",
354354
OPAL_INFO_LVL_9, &cs->han_gather_low_module,
355355
&cs->han_op_module_name.gather.han_op_low_module_name);
356356

@@ -374,7 +374,7 @@ static int han_register(void)
374374

375375
cs->han_scatter_low_module = 0;
376376
(void) mca_coll_han_query_module_from_mca(c, "scatter_low_module",
377-
"low level module for scatter, 0 tuned, 1 sm",
377+
"low level module for scatter, currently only 0 tuned",
378378
OPAL_INFO_LVL_9, &cs->han_scatter_low_module,
379379
&cs->han_op_module_name.scatter.han_op_low_module_name);
380380

ompi/mca/coll/han/coll_han_dynamic.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ typedef enum COMPONENTS {
111111
typedef struct {
112112
COMPONENT_T id;
113113
char* component_name;
114-
mca_coll_base_component_t* component;
115114
} ompi_coll_han_components;
116115

117116
extern ompi_coll_han_components ompi_coll_han_available_components[COMPONENTS_COUNT];

ompi/mca/coll/sm/Makefile.am

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)