Skip to content

Commit 2c36d37

Browse files
authored
Merge pull request #7871 from devreal/osc-ucx-rget-rput-fetch-alignment
OSC UCX: make sure no-op fetch in rget/rput is properly aligned
2 parents fdf704c + c1f7776 commit 2c36d37

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ompi/mca/osc/ucx/osc_ucx_comm.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,9 +1086,10 @@ int ompi_osc_ucx_rput(const void *origin_addr, int origin_count,
10861086
}
10871087

10881088
mca_osc_ucx_component.num_incomplete_req_ops++;
1089+
/* TODO: investigate whether ucp_worker_flush_nb is a better choice here */
10891090
ret = opal_common_ucx_wpmem_fetch_nb(module->mem, UCP_ATOMIC_FETCH_OP_FADD,
10901091
0, target, &(module->req_result),
1091-
sizeof(uint64_t), remote_addr,
1092+
sizeof(uint64_t), remote_addr & (~0x7),
10921093
req_completion, ucx_req);
10931094
if (ret != OMPI_SUCCESS) {
10941095
OMPI_OSC_UCX_REQUEST_RETURN(ucx_req);
@@ -1138,9 +1139,10 @@ int ompi_osc_ucx_rget(void *origin_addr, int origin_count,
11381139
}
11391140

11401141
mca_osc_ucx_component.num_incomplete_req_ops++;
1142+
/* TODO: investigate whether ucp_worker_flush_nb is a better choice here */
11411143
ret = opal_common_ucx_wpmem_fetch_nb(module->mem, UCP_ATOMIC_FETCH_OP_FADD,
11421144
0, target, &(module->req_result),
1143-
sizeof(uint64_t), remote_addr,
1145+
sizeof(uint64_t), remote_addr & (~0x7),
11441146
req_completion, ucx_req);
11451147
if (ret != OMPI_SUCCESS) {
11461148
OMPI_OSC_UCX_REQUEST_RETURN(ucx_req);

0 commit comments

Comments
 (0)