Skip to content

Commit 2b5a5a7

Browse files
bwbarrettjsquyres
authored andcommitted
opal_check_cflags.m4: fix underquoting
Properly quoting the argument to _OPAL_CXXFLAGS_FAIL_SEARCH fixes a confusing-and-misleading-but-ultimately-accurate warning from Autoconf 2.7x (the warning specifically mentions a circular dependency on AC_PROG_GREP). Signed-off-by: Brian Barrett <bbarrett@amazon.com> Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 45c189a)
1 parent ab8b228 commit 2b5a5a7

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

config/opal_check_cflags.m4

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,12 @@ AC_MSG_CHECKING(if $CC supports ([$1]))
2828
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [$3])],
2929
[
3030
opal_cv_cc_[$2]=1
31-
_OPAL_CFLAGS_FAIL_SEARCH("ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown", [$2])
31+
_OPAL_CFLAGS_FAIL_SEARCH(["ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown"], [$2])
3232
],
33+
[
3334
opal_cv_cc_[$2]=1
34-
_OPAL_CFLAGS_FAIL_SEARCH("ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown\|error", [$2])
35-
)])
35+
_OPAL_CFLAGS_FAIL_SEARCH(["ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown\|error"], [$2])
36+
])])
3637
if test "$opal_cv_cc_[$2]" = "0" ; then
3738
CFLAGS="$CFLAGS_orig"
3839
AC_MSG_RESULT([no])
@@ -59,11 +60,12 @@ AC_MSG_CHECKING(if $CXX supports ([$1]))
5960
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [$3])],
6061
[
6162
opal_cv_cxx_[$2]=1
62-
_OPAL_CXXFLAGS_FAIL_SEARCH("ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown", [$2])
63+
_OPAL_CXXFLAGS_FAIL_SEARCH(["ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown"], [$2])
6364
],
65+
[
6466
opal_cv_cxx_[$2]=1
65-
_OPAL_CXXFLAGS_FAIL_SEARCH("ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown\|error", [$2])
66-
)])
67+
_OPAL_CXXFLAGS_FAIL_SEARCH(["ignored\|not recognized\|not supported\|not compatible\|unrecognized\|unknown\|error"], [$2])
68+
])])
6769
if test "$opal_cv_cxx_[$2]" = "0" ; then
6870
CXXFLAGS="$CXXFLAGS_orig"
6971
AC_MSG_RESULT([no])

0 commit comments

Comments
 (0)