oshmem: Remove dead codes during oshmem communicator creation

oshmem uses oshmem_group_t structure during communicator creation.
However, it consists a peer_list of type opal_list_t. However, the
peer_list field is not used anywhere inside oshmem. Removing the
peer_list field from the oshmem_group_t structure to save additional
memory consumption.

Co-authored-by: Artem Y. Polyakov <artemp@nvidia.com>
Signed-off-by: Subhadeep Bhattacharya <subhadeepb@nvidia.com>
Signed-off-by: Artem Polyakov <artemp@nvidia.com>

Author: sb17v

oshmem/mca/spml/ucx/spml_ucx.c

@@ -10,7 +10,7 @@
  *
  * $HEADER$
  */
-
+ 
 #define _GNU_SOURCE
 #include <stdio.h>
 

oshmem/mca/spml/ucx/spml_ucx.h

@@ -261,7 +261,7 @@ mca_spml_ucx_ctx_mkey_by_va(shmem_ctx_t ctx, int pe, void *va, void **rva, mca_s
 {
     spml_ucx_cached_mkey_t **mkey;
     mca_spml_ucx_ctx_t *ucx_ctx = (mca_spml_ucx_ctx_t *)ctx;
-    int i;
+    size_t i;
 
     mkey = ucx_ctx->ucp_peers[pe].mkeys;
     for (i = 0; i < ucx_ctx->ucp_peers[pe].mkeys_cnt; i++) {

oshmem/proc/proc.c

@@ -78,8 +78,6 @@ int oshmem_proc_init(void)
         return ret;
     }
 
-    /* check oshmem_proc_data_t can fit within ompi_proc_t padding */
-    assert(sizeof(oshmem_proc_data_t) <= OMPI_PROC_PADDING_SIZE);
     /* check ompi_proc_t padding is aligned on a pointer */
     assert(0 == (offsetof(ompi_proc_t, padding) & (sizeof(char *)-1)));
 
@@ -192,7 +190,6 @@ oshmem_group_t* oshmem_proc_group_create(int pe_start, int pe_stride, int pe_siz
     int cur_pe, count_pe;
     int i;
     oshmem_group_t* group = NULL;
-    ompi_proc_t* proc = NULL;
 
     assert(oshmem_proc_local());
 
@@ -234,19 +231,6 @@ oshmem_group_t* oshmem_proc_group_create(int pe_start, int pe_stride, int pe_siz
     }
     group->proc_count = (int) count_pe;
     group->ompi_comm = NULL;
-
-    /* Prepare peers list */
-    OBJ_CONSTRUCT(&(group->peer_list), opal_list_t);
-    {
-        opal_namelist_t *peer = NULL;
-
-        for (i = 0; i < group->proc_count; i++) {
-            peer = OBJ_NEW(opal_namelist_t);
-            peer->name.jobid = group->proc_vpids[i];
-            peer->name.vpid = OMPI_PROC_MY_NAME->jobid;
-            opal_list_append(&(group->peer_list), &peer->super);
-        }
-    }
     group->id = opal_pointer_array_add(&oshmem_group_array, group);
 
     memset(&group->g_scoll, 0, sizeof(mca_scoll_base_group_scoll_t));
@@ -287,17 +271,6 @@ oshmem_proc_group_destroy_internal(oshmem_group_t* group, int scoll_unselect)
         free(group->proc_vpids);
     }
 
-    /* Destroy peer list */
-    {
-        opal_list_item_t *item;
-
-        while (NULL != (item = opal_list_remove_first(&(group->peer_list)))) {
-            /* destruct the item (we constructed it), then free the memory chunk */
-            OBJ_RELEASE(item);
-        }
-        OBJ_DESTRUCT(&(group->peer_list));
-    }
-
     /* reset the oshmem_group_array entry - make sure that the
      * entry is in the table */
     if (NULL

oshmem/proc/proc.h

@@ -39,19 +39,6 @@ struct oshmem_group_t;
 
 #define OSHMEM_PE_INVALID   (-1)
 
-/* This struct will be copied into the padding field of an ompi_proc_t
- * so the size of oshmem_proc_data_t must be less or equal than
- * OMPI_PROC_PADDING_SIZE */
-struct oshmem_proc_data_t {
-    char * transport_ids;
-    int num_transports;
-};
-
-typedef struct oshmem_proc_data_t oshmem_proc_data_t;
-
-#define OSHMEM_PROC_DATA(proc) \
-    ((oshmem_proc_data_t *)(proc)->padding)
-
 /**
  * Group of Open SHMEM processes structure
  *
@@ -64,7 +51,6 @@ struct oshmem_group_t {
     int                         proc_count;     /**< number of processes in group */
     int                         is_member;   /* true if my_pe is part of the group, participate in collectives */
     opal_vpid_t                 *proc_vpids; /* vpids of each process in group */
-    opal_list_t                 peer_list;
 
     /* Collectives module interface and data */
     mca_scoll_base_group_scoll_t g_scoll;
@@ -164,7 +150,6 @@ static inline int oshmem_proc_pe(ompi_proc_t *proc)
     return (proc ? (int) ((ompi_process_name_t*)&proc->super.proc_name)->vpid : -1);
 }
 
-int oshmem_proc_init_set_local_vpids();
 bool oshmem_proc_on_local_node(int pe);
 /**
  * Initialize the OSHMEM process predefined groups