opal/os_path: fix minor string overrun

jsquyres · jsquyres · commit 290d1c0534c1 · 2018-10-17T08:57:30.000-07:00
This is a follow on to 54ca331 to fix a minor bug identified by Coverity. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
diff --git a/opal/util/os_path.c b/opal/util/os_path.c
@@ -59,7 +59,7 @@ char *opal_os_path(int relative, ...)
     	if (relative) {
             path[0] = '.';
         }
-        strncat(path, path_sep, len);
+        strncat(path, path_sep, len - 1);
     	return(path);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ char *opal_os_path(int relative, ...)`
`59`	`59`	`if (relative) {`
`60`	`60`	`path[0] = '.';`
`61`	`61`	`}`
`62`		`- strncat(path, path_sep, len);`
	`62`	`+ strncat(path, path_sep, len - 1);`
`63`	`63`	`return(path);`
`64`	`64`	`}`
`65`	`65`