Skip to content

Commit 28732cb

Browse files
author
Luke Robison
committed
coll/base: Correct comment about sendrecv and 0-byte messages
Previously the comment suggested 0-byte sends were skipped, but this was no longer accurate. Update the comment to reflect the implementation. Signed-off-by: Luke Robison <lrbison@amazon.com>
1 parent a20ec90 commit 28732cb

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

ompi/mca/coll/base/coll_base_util.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ OMPI_DECLSPEC OBJ_CLASS_DECLARATION(mca_coll_base_avail_coll_t);
111111

112112
/**
113113
* A MPI_like function doing a send and a receive simultaneously.
114-
* If one of the communications results in a zero-byte message the
115-
* communication is ignored, and no message will cross to the peer.
114+
* Posts a irecv, does a send, then gets irecv completion.
116115
*/
117116
int ompi_coll_base_sendrecv_actual( const void* sendbuf, size_t scount,
118117
ompi_datatype_t* sdatatype,
@@ -125,10 +124,8 @@ int ompi_coll_base_sendrecv_actual( const void* sendbuf, size_t scount,
125124

126125

127126
/**
128-
* Similar to the function above this implementation of send-receive
129-
* do not generate communications for zero-bytes messages. Thus, it is
130-
* improper to use in the context of some algorithms for collective
131-
* communications.
127+
* A wrapper around ompi_coll_base_sendrecv_actual, with an optimized
128+
* path for self-directed send/recv.
132129
*/
133130
static inline int
134131
ompi_coll_base_sendrecv( void* sendbuf, size_t scount, ompi_datatype_t* sdatatype,

0 commit comments

Comments
 (0)