Skip to content

Commit 2798ee4

Browse files
authored
Merge pull request #8461 from rajachan/package_rank_warn
common/ofi: Use opal_show_help() to call out lack of locality info
2 parents 5cf720d + c91063f commit 2798ee4

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

opal/mca/common/ofi/common_ofi.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,10 +340,10 @@ static uint32_t get_package_rank(opal_process_info_t *process_info)
340340
&pname, &locality_string, PMIX_STRING);
341341
if (PMIX_SUCCESS != rc || NULL == locality_string) {
342342
// If we don't have information about locality, fall back to procid
343-
opal_output_verbose(1, opal_common_ofi.output,
344-
"%s:%d:Unable to get locality string from local peers.\n"
345-
"This may negatively impact performance.\n",
346-
__FILE__, __LINE__);
343+
int level = 10;
344+
if (opal_output_get_verbosity(opal_common_ofi.output) >= level) {
345+
opal_show_help("help-common-ofi.txt", "package_rank failed", true, level);
346+
}
347347
return (uint32_t)process_info->myprocid.rank;
348348
}
349349

opal/mca/common/ofi/help-common-ofi.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@ Open MPI's OFI driver detected multiple equidistant NICs from the current proces
1212
but had insufficient information to ensure MPI processes fairly pick a NIC for use.
1313
This may negatively impact performance. A more modern PMIx server is necessary to
1414
resolve this issue.
15+
16+
Note: This message is displayed only when the OFI component's verbosity level is
17+
%d or higher.

0 commit comments

Comments
 (0)