Skip to content

Commit 22f773e

Browse files
committed
Fix a crash during CUDA initialization
From a valgrind log: ``` ==2935008== Conditional jump or move depends on uninitialised value(s) ==2935008== at 0x54D70D5: pmix_bfrops_base_value_unload (bfrop_base_fns.c:358) ==2935008== by 0x54D61CB: pmix_value_unload (bfrop_base_fns.c:49) ==2935008== by 0x527BBD2: smcuda_btl_first_time_init (btl_smcuda.c:269) ==2935008== by 0x527CA5F: mca_btl_smcuda_add_procs (btl_smcuda.c:597) ==2935011== Conditional jump or move depends on uninitialised value(s) ==2935011== at 0x54D70D5: pmix_bfrops_base_value_unload (bfrop_base_fns.c:358) ==2935008== by 0x4F0CB95: mca_bml_r2_add_procs (bml_r2.c:526) ==2935008== by 0x50B04A4: mca_pml_ob1_add_procs (pml_ob1.c:343) ==2935008== by 0x4E75867: ompi_mpi_init (ompi_mpi_init.c:853) ==2935008== by 0x4EC4B30: PMPI_Init (pinit.c:67) ==2935011== by 0x54D61CB: pmix_value_unload (bfrop_base_fns.c:49) ==2935011== by 0x527BBD2: smcuda_btl_first_time_init (btl_smcuda.c:269) ==2935011== by 0x527CA5F: mca_btl_smcuda_add_procs (btl_smcuda.c:597) ==2935011== by 0x4F0CB95: mca_bml_r2_add_procs (bml_r2.c:526) ==2935010== Conditional jump or move depends on uninitialised value(s) ==2935010== at 0x54D70D5: pmix_bfrops_base_value_unload (bfrop_base_fns.c:358) ==2935010== by 0x54D61CB: pmix_value_unload (bfrop_base_fns.c:49) ==2935010== by 0x52927D4: opal_hwloc_base_get_topology (hwloc_base_util.c:316) ==2935010== by 0x5280A4B: mca_btl_smcuda_component_init (btl_smcuda_component.c:882) ==2935010== by 0x526C3F5: mca_btl_base_select (btl_base_select.c:110) ==2935010== by 0x4F0DEC5: mca_bml_r2_component_init (bml_r2_component.c:88) ==2935010== by 0x4F0B3A9: mca_bml_base_init (bml_base_init.c:74) ==2935010== by 0x4E7521E: ompi_mpi_init (ompi_mpi_init.c:609) ==2935010== by 0x4EC4B30: PMPI_Init (pinit.c:67) ``` Signed-off-by: Yaz Saito <yasushi.saito@gmail.com>
1 parent 4f81935 commit 22f773e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

ompi/proc/proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ int ompi_proc_complete_init(void)
304304
opal_process_name_t wildcard_rank;
305305
ompi_proc_t *proc;
306306
int ret, errcode = OMPI_SUCCESS;
307-
char *val;
307+
char *val = NULL;
308308

309309
opal_mutex_lock (&ompi_proc_lock);
310310

opal/mca/btl/smcuda/btl_smcuda.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ smcuda_btl_first_time_init(mca_btl_smcuda_t *smcuda_btl,
251251
free(loc);
252252
} else {
253253
/* If we have hwloc support, then get accurate information */
254+
loc = NULL;
254255
if (OPAL_SUCCESS == opal_hwloc_base_get_topology()) {
255256
i = opal_hwloc_base_get_nbobjs_by_type(opal_hwloc_topology,
256257
HWLOC_OBJ_NODE, 0,

0 commit comments

Comments
 (0)