Skip to content

Commit 1e11933

Browse files
committed
ompi: cleanup C++ MPI::ERRORS_THROW_EXCEPTIONS
The C++ bindings were removed a while ago; MPI::ERRORS_THROW_EXCEPTIONS and MPI_ERRORS_THROW_EXCEPTIONS no longer exist. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
1 parent f3832c1 commit 1e11933

File tree

3 files changed

+0
-32
lines changed

3 files changed

+0
-32
lines changed

ompi/debuggers/ompi_mpihandles_dll.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,6 @@ int mpidbg_init_per_process(mqs_process *process,
390390
&mpidbg_errhandler_name_map[i++]);
391391
fill_map(image, "MPI_ERRHANDLER_NULL", "ompi_mpi_errhandler_null",
392392
&mpidbg_errhandler_name_map[i++]);
393-
/* MPI::ERRORS_THROW_EXCEPTIONS exists as a symbol in OMPI; no
394-
need to alias it here */
395393

396394
/* Sentinel value */
397395
mpidbg_errhandler_name_map[i].map_name = NULL;

ompi/errhandler/errhandler.c

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ ompi_predefined_errhandler_t *ompi_mpi_errors_abort_addr =
7474
ompi_predefined_errhandler_t ompi_mpi_errors_return = {{{0}}};
7575
ompi_predefined_errhandler_t *ompi_mpi_errors_return_addr =
7676
&ompi_mpi_errors_return;
77-
ompi_predefined_errhandler_t ompi_mpi_errors_throw_exceptions = {{{0}}};
78-
ompi_predefined_errhandler_t *ompi_mpi_errors_throw_exceptions_addr =
79-
&ompi_mpi_errors_throw_exceptions;
8077

8178
static opal_mutex_t errhandler_init_lock = OPAL_MUTEX_STATIC_INIT;
8279
ompi_errhandler_t* ompi_initial_error_handler_eh = NULL;
@@ -192,26 +189,6 @@ int ompi_errhandler_init(void)
192189
"MPI_ERRORS_ABORT",
193190
sizeof(ompi_mpi_errors_abort.eh.eh_name));
194191

195-
/* If we're going to use C++, functions will be fixed up during
196-
MPI::Init. Note that it is proper to use ERRHANDLER_LANG_C here;
197-
the dispatch function is in C (although in libmpi_cxx); the
198-
conversion from C handles to C++ handles happens in that dispatch
199-
function -- not the errhandler_invoke.c stuff here in libmpi. */
200-
OBJ_CONSTRUCT( &ompi_mpi_errors_throw_exceptions.eh, ompi_errhandler_t );
201-
ompi_mpi_errors_throw_exceptions.eh.eh_mpi_object_type =
202-
OMPI_ERRHANDLER_TYPE_PREDEFINED;
203-
ompi_mpi_errors_throw_exceptions.eh.eh_lang = OMPI_ERRHANDLER_LANG_C;
204-
ompi_mpi_errors_throw_exceptions.eh.eh_comm_fn =
205-
ompi_mpi_errors_are_fatal_comm_handler;
206-
ompi_mpi_errors_throw_exceptions.eh.eh_file_fn =
207-
ompi_mpi_errors_are_fatal_file_handler;
208-
ompi_mpi_errors_throw_exceptions.eh.eh_win_fn =
209-
ompi_mpi_errors_are_fatal_win_handler ;
210-
ompi_mpi_errors_throw_exceptions.eh.eh_fort_fn = NULL;
211-
opal_string_copy(ompi_mpi_errors_throw_exceptions.eh.eh_name,
212-
"MPI_ERRORS_THROW_EXCEPTIONS",
213-
sizeof(ompi_mpi_errors_throw_exceptions.eh.eh_name));
214-
215192
/* Lets initialize the initial error handler if not already done */
216193
char *env = getenv("OMPI_MCA_mpi_initial_errhandler");
217194
if( NULL != env ) {
@@ -228,7 +205,6 @@ int ompi_errhandler_finalize(void)
228205
{
229206
OBJ_DESTRUCT(&ompi_mpi_errhandler_null.eh);
230207
OBJ_DESTRUCT(&ompi_mpi_errors_return.eh);
231-
OBJ_DESTRUCT(&ompi_mpi_errors_throw_exceptions.eh);
232208
OBJ_DESTRUCT(&ompi_mpi_errors_are_fatal.eh);
233209

234210
/* JMS Add stuff here checking for unreleased errorhandlers,

ompi/errhandler/errhandler.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,12 +175,6 @@ OMPI_DECLSPEC extern ompi_predefined_errhandler_t *ompi_mpi_errors_return_addr;
175175
OMPI_DECLSPEC extern ompi_predefined_errhandler_t ompi_mpi_errors_abort;
176176
OMPI_DECLSPEC extern ompi_predefined_errhandler_t *ompi_mpi_errors_abort_addr;
177177

178-
/**
179-
* Global variable for MPI::ERRORS_THROW_EXCEPTIONS. Will abort if
180-
* MPI_INIT wasn't called as MPI::INIT (_addr flavor is for F03 bindings)
181-
*/
182-
OMPI_DECLSPEC extern ompi_predefined_errhandler_t ompi_mpi_errors_throw_exceptions;
183-
184178
/**
185179
* Table for Fortran <-> C errhandler handle conversion
186180
*/

0 commit comments

Comments
 (0)