Skip to content

Commit 17d3873

Browse files
committed
Keep internal symbols from being visible in the GOT.
Signed-off-by: George Bosilca <gbosilca@nvidia.com>
1 parent bc03edf commit 17d3873

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

opal/mca/accelerator/rocm/accelerator_rocm.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ typedef struct {
4141
} opal_accelerator_rocm_component_t;
4242

4343
OPAL_DECLSPEC extern opal_accelerator_rocm_component_t mca_accelerator_rocm_component;
44-
OPAL_DECLSPEC extern opal_accelerator_base_module_t opal_accelerator_rocm_module;
44+
extern opal_accelerator_base_module_t opal_accelerator_rocm_module;
4545

4646
struct opal_accelerator_rocm_stream_t {
4747
opal_accelerator_stream_t base;
@@ -67,12 +67,12 @@ struct opal_accelerator_rocm_ipc_event_handle_t {
6767
typedef struct opal_accelerator_rocm_ipc_event_handle_t opal_accelerator_rocm_ipc_event_handle_t;
6868
OBJ_CLASS_DECLARATION(opal_accelerator_rocm_ipc_event_handle_t);
6969

70-
OPAL_DECLSPEC extern hipStream_t opal_accelerator_rocm_MemcpyStream;
71-
OPAL_DECLSPEC extern int opal_accelerator_rocm_memcpy_async;
72-
OPAL_DECLSPEC extern int opal_accelerator_rocm_verbose;
73-
OPAL_DECLSPEC extern size_t opal_accelerator_rocm_memcpyH2D_limit;
74-
OPAL_DECLSPEC extern size_t opal_accelerator_rocm_memcpyD2H_limit;
70+
extern hipStream_t opal_accelerator_rocm_MemcpyStream;
71+
extern int opal_accelerator_rocm_memcpy_async;
72+
extern int opal_accelerator_rocm_verbose;
73+
extern size_t opal_accelerator_rocm_memcpyH2D_limit;
74+
extern size_t opal_accelerator_rocm_memcpyD2H_limit;
7575

76-
OPAL_DECLSPEC extern int opal_accelerator_rocm_lazy_init(void);
76+
extern int opal_accelerator_rocm_lazy_init(void);
7777

7878
#endif

opal/mca/accelerator/rocm/accelerator_rocm_component.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ int opal_accelerator_rocm_lazy_init()
176176

177177
err = hipStreamCreate(&opal_accelerator_rocm_MemcpyStream);
178178
if (hipSuccess != err) {
179+
err = OPAL_ERROR; // we got hipErrorInvalidValue, pretty bad
179180
opal_output(0, "Could not create hipStream, err=%d %s\n",
180181
err, hipGetErrorString(err));
181182
goto out;

0 commit comments

Comments
 (0)