Fix SIGSEGV due to null pointer in [200~hook_comm_method_fns.c(comm_method_sring)

David Wootton · David Wootton · commit 01f7f9e9b6ee · 2022-06-01T09:02:34.000-04:00
if no UCX tnsport info returned

Signed-off-by: David Wootton &lt;dwootton@us.ibm.com&gt;
diff --git a/ompi/mca/hook/comm_method/hook_comm_method_fns.c b/ompi/mca/hook/comm_method/hook_comm_method_fns.c
@@ -144,13 +144,13 @@ comm_method_string(MPI_Comm comm, int rank, int *comm_mode) {
             strcat(string, ";");
             strcat(string, transports->entries[i].device_name);
         }
+        free(transports->entries);
+        free(transports);
     }
     if (comm_mode) {
         // UCX is used for PML mode only
         *comm_mode = MODE_IS_PML;
     }
-    free(transports->entries);
-    free(transports);
     return string;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -144,13 +144,13 @@ comm_method_string(MPI_Comm comm, int rank, int *comm_mode) {`
`144`	`144`	`strcat(string, ";");`
`145`	`145`	`strcat(string, transports->entries[i].device_name);`
`146`	`146`	`}`
	`147`	`+ free(transports->entries);`
	`148`	`+ free(transports);`
`147`	`149`	`}`
`148`	`150`	`if (comm_mode) {`
`149`	`151`	`// UCX is used for PML mode only`
`150`	`152`	`*comm_mode = MODE_IS_PML;`
`151`	`153`	`}`
`152`		`- free(transports->entries);`
`153`		`- free(transports);`
`154`	`154`	`return string;`
`155`	`155`	`}`
`156`	`156`