opal/asm: fix 32-bit fetch and op atomics

hjelmn · hjelmn · commit 009a3f093b9a · 2018-06-14T13:54:52.000-06:00
These functions were erroneously returing the new, not the old value.

Signed-off-by: Nathan Hjelm &lt;hjelmn@lanl.gov&gt;
diff --git a/opal/include/opal/sys/powerpc/atomic.h b/opal/include/opal/sys/powerpc/atomic.h
@@ -11,7 +11,7 @@
  * Copyright (c) 2004-2005 The Regents of the University of California.
  *                         All rights reserved.
  * Copyright (c) 2010-2017 IBM Corporation.  All rights reserved.
- * Copyright (c) 2015-2017 Los Alamos National Security, LLC. All rights
+ * Copyright (c) 2015-2018 Los Alamos National Security, LLC. All rights
  *                         reserved.
  * $COPYRIGHT$
  *
@@ -414,7 +414,7 @@ static inline int32_t opal_atomic_fetch_ ## type ## _32(volatile int32_t* v, int
                          : "r" (val), "r" OPAL_ASM_ADDR(v), "m" (*v)    \
                          : "cc");                                       \
                                                                         \
-    return t;                                                           \
+    return old;                                                         \
 }
 
 OPAL_ATOMIC_POWERPC_DEFINE_ATOMIC_32(add, add)

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* Copyright (c) 2004-2005 The Regents of the University of California.`
`12`	`12`	`* All rights reserved.`
`13`	`13`	`* Copyright (c) 2010-2017 IBM Corporation. All rights reserved.`
`14`		`- * Copyright (c) 2015-2017 Los Alamos National Security, LLC. All rights`
	`14`	`+ * Copyright (c) 2015-2018 Los Alamos National Security, LLC. All rights`
`15`	`15`	`* reserved.`
`16`	`16`	`* $COPYRIGHT$`
`17`	`17`	`*`
`@@ -414,7 +414,7 @@ static inline int32_t opal_atomic_fetch_ ## type ## _32(volatile int32_t* v, int`
`414`	`414`	`: "r" (val), "r" OPAL_ASM_ADDR(v), "m" (*v) \`
`415`	`415`	`: "cc"); \`
`416`	`416`	`\`
`417`		`- return t; \`
	`417`	`+ return old; \`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`OPAL_ATOMIC_POWERPC_DEFINE_ATOMIC_32(add, add)`