Skip to content

Commit 71145ff

Browse files
committed
adding more symbols to the allowed-list in nmcheck
I don't want this testcase to be too aggressive about declaring errors for things that might be okay. Things allowed by this checkin that definitely should be allowed: libhwloc.so can have hwloc_ symbols libpmix.so can have pmix_ symbols I'm also allowing PQ_ which seems unlikely to conflict with user-apps and comes from treematch. Signed-off-by: Mark Allen <markalle@us.ibm.com>
1 parent 684531f commit 71145ff

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

packaging/nmcheck_prefix.pl

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,18 @@ sub check_lib_for_bad_exports {
124124
@symbols = grep(!/^tm_/, @symbols); # tempted to require ompi_ here
125125
@symbols = grep(!/^mca_/, @symbols);
126126
@symbols = grep(!/^smpi_/, @symbols);
127+
@symbols = grep(!/^MPL_/, @symbols);
128+
@symbols = grep(!/^MPLI_/, @symbols);
129+
@symbols = grep(!/^PQ_/, @symbols);
130+
131+
# libhwloc can have hwloc_ symbols of course, and
132+
# libpmix can have pmix_*:
133+
if ($lib =~ /libhwloc\./) {
134+
@symbols = grep(!/^hwloc_/, @symbols);
135+
}
136+
if ($lib =~ /libpmix\./) {
137+
@symbols = grep(!/^pmix[0-9]*_/, @symbols);
138+
}
127139

128140
@symbols = grep(!/^_fini$/, @symbols);
129141
@symbols = grep(!/^_init$/, @symbols);

0 commit comments

Comments
 (0)