Skip to content

Commit 8d18ce8

Browse files
jfsmigfvennetier
authored andcommitted
gridinit_cmd: Less nested funcs
1 parent d3a2902 commit 8d18ce8

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

main/gridinit_cmd.c

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -483,30 +483,32 @@ _fetch_services(GList **out)
483483
}
484484
}
485485

486-
static GList *
487-
_filter_services(GList *original, char **filters, int *counters)
486+
static gboolean
487+
_filter_matches_srv(struct child_info_s *ci, char **filters, int *counters)
488488
{
489-
gboolean matches(struct child_info_s *ci) {
490-
for (int i=0; filters[i] ;i++) {
491-
const char *pattern = filters[i];
492-
if (pattern[0]=='@') {
493-
if (gridinit_group_in_set(pattern+1, ci->group)) {
494-
if (counters) counters[i] ++;
495-
return TRUE;
496-
}
497-
} else {
498-
if (!g_ascii_strcasecmp(ci->key, pattern)) {
499-
if (counters) counters[i] ++;
500-
return TRUE;
501-
}
489+
for (int i=0; filters[i] ;i++) {
490+
const char *pattern = filters[i];
491+
if (pattern[0]=='@') {
492+
if (gridinit_group_in_set(pattern+1, ci->group)) {
493+
if (counters) counters[i] ++;
494+
return TRUE;
495+
}
496+
} else {
497+
if (!g_ascii_strcasecmp(ci->key, pattern)) {
498+
if (counters) counters[i] ++;
499+
return TRUE;
502500
}
503501
}
504-
return FALSE;
505502
}
503+
return FALSE;
504+
}
506505

506+
static GList *
507+
_filter_services(GList *original, char **filters, int *counters)
508+
{
507509
GList *result = NULL;
508510
for (GList *l = original; l ;l = l->next) {
509-
if (!filters[0] || matches(l->data)) {
511+
if (!filters[0] || _filter_matches_srv(l->data, filters, counters)) {
510512
result = g_list_append(result, l->data);
511513
}
512514
}

0 commit comments

Comments
 (0)