feat: validate template webhook deletion protection (#15)

Author: jokuniew

.test-dependencies.yaml

@@ -142,7 +142,7 @@ components:
         package: "edge-orch/cluster/charts/cluster-manager"
         namespace: "default"
         version: ""  # Use the latest version when nil
-        overrides: "--set clusterManager.extraArgs.disable-mt=true --set clusterManager.extraArgs.disable-auth=true --set clusterManager.extraArgs.disable-inventory=true"
+        overrides: "--set clusterManager.extraArgs.disable-mt=true --set clusterManager.extraArgs.disable-auth=true --set clusterManager.extraArgs.disable-inventory=true --set templateController.extraArgs[0]='--webhook-enabled=true' --set webhookService.enabled=true"
       - url: "oci://registry-rs.edgeorchestration.intel.com"
         release-name: "cluster-template-crd"
         package: "edge-orch/cluster/charts/cluster-template-crd"

test-plan/test-plan.md

@@ -197,3 +197,16 @@ Test Case format shall look like below:
   1. Use kubeconfig to fetch list of pods
 - **Expected Results:**
   - The pod list information is retrieved successfully.
+
+### Test Case ID: TC-CO-INT-009
+
+- **Test Description:** Should verify that a cluster template cannot be deleted if there is a cluster using it.
+- **Preconditions:**
+  - Ensure the namespace exists or create it if it does not.
+  - Port forward to the cluster manager service.
+  - Import the cluster template and ensure it is ready.
+  - Create a cluster using the imported cluster template.
+- **Test Steps:**
+  1. Attempt to delete the cluster template using the DELETE API.
+- **Expected Results:**
+  - The DELETE request fails with an error message indicating that the cluster template is in use.

tests/functional-test/cluster_orch_functional_test.go

@@ -20,12 +20,14 @@ import (
 )
 
 const (
-	defaultNamespace             = "53cd37b9-66b2-4cc8-b080-3722ed7af64a"
-	defaultNodeGUID              = "12345678-1234-1234-1234-123456789012"
-	namespaceEnvVar              = "NAMESPACE"
-	nodeGUIDEnvVar               = "NODEGUID"
-	clusterName                  = "demo-cluster"
-	clusterTemplateName          = "baseline-v2.0.1"
+	defaultNamespace = "53cd37b9-66b2-4cc8-b080-3722ed7af64a"
+	defaultNodeGUID  = "12345678-1234-1234-1234-123456789012"
+	namespaceEnvVar  = "NAMESPACE"
+	nodeGUIDEnvVar   = "NODEGUID"
+	clusterName      = "demo-cluster"
+
+	clusterTemplateOnlyName      = "baseline"
+	clusterTemplateOnlyVersion   = "v2.0.1"
 	clusterOrchFunctionalTest    = "cluster-orch-functional-test"
 	portForwardAddress           = "0.0.0.0"
 	portForwardService           = "svc/cluster-manager"
@@ -41,7 +43,8 @@ const (
 )
 
 var (
-	skipDeleteCluster = os.Getenv("SKIP_DELETE_CLUSTER") == "true"
+	clusterTemplateName = fmt.Sprintf("%s-%s", clusterTemplateOnlyName, clusterTemplateOnlyVersion)
+	skipDeleteCluster   = os.Getenv("SKIP_DELETE_CLUSTER") == "true"
 )
 
 func TestClusterOrchFunctionalTest(t *testing.T) {
@@ -190,6 +193,12 @@ var _ = Describe("Cluster Orch Functional tests", Ordered, Label(clusterOrchFunc
 		_, err = cmd.Output()
 		Expect(err).NotTo(HaveOccurred())
 	})
+	It("TC-CO-INT-009: Should verify that a cluster template cannot be deleted if there is a cluster using it", func() {
+		By("Trying to delete the cluster template")
+		err := deleteTemplate(namespace)
+		Expect(err).To(HaveOccurred())
+		Expect(err.Error()).To(ContainSubstring("denied the request: clusterTemplate is in use"))
+	})
 	// TODO: Add more functional tests
 })
 
@@ -355,6 +364,33 @@ func deleteCluster(namespace string) error {
 	return nil
 }
 
+func deleteTemplate(namespace string) error {
+	url := fmt.Sprintf("%s/%s/%s", clusterTemplateURL, clusterTemplateOnlyName, clusterTemplateOnlyVersion)
+
+	req, err := http.NewRequest("DELETE", url, nil)
+	if err != nil {
+		return err
+	}
+
+	req.Header.Set("Activeprojectid", namespace)
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("Accept", "application/json")
+
+	client := &http.Client{}
+	resp, err := client.Do(req)
+	if err != nil {
+		return err
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusNoContent {
+		body, _ := io.ReadAll(resp.Body)
+		return fmt.Errorf("failed to delete template: %s", string(body))
+	}
+
+	return nil
+}
+
 func getClusterInfo(namespace, clusterName string) (*http.Response, error) {
 	url := fmt.Sprintf("%s/%s", clusterCreateURL, clusterName)
 	req, err := http.NewRequest("GET", url, nil)