clarify dimensionality checks for dimensionless units (thanks @AgnieszkaZaba for hint) (#1512)

Author: slayoo

tests/smoke_tests/box/srivastava_1982/test_equations.py

@@ -17,7 +17,7 @@ def test_eq10(self):
             m_e = eqs.eq10(m0=0.1 * si.kg / frag_mass, tau=eqs.tau(1 * si.s))
 
             # assert
-            assert m_e.check("[]")
+            assert m_e.check(si.dimensionless)
 
     def test_eq12(self):
         with DimensionalAnalysis():
@@ -30,7 +30,7 @@ def test_eq12(self):
             m_e = eqs.eq12()
 
             # assert
-            assert m_e.check("[]")
+            assert m_e.check(si.dimensionless)
 
     def test_eq13(self):
         with DimensionalAnalysis():
@@ -43,7 +43,7 @@ def test_eq13(self):
             m_e = eqs.eq13(m0=0.1 * si.kg / frag_mass, tau=eqs.tau(1 * si.s))
 
             # assert
-            assert m_e.check("[]")
+            assert m_e.check(si.dimensionless)
 
     def test_eq14(self):
         with DimensionalAnalysis():
@@ -55,4 +55,4 @@ def test_eq14(self):
             m_e = eqs.eq14()
 
             # assert
-            assert m_e.check("[]")
+            assert m_e.check(si.dimensionless)

tests/unit_tests/physics/test_optical.py

@@ -24,7 +24,7 @@ def test_albedo_unit(paper):
             albedo = formulae.optical_albedo.albedo(tau)
 
             # assert
-            assert albedo.check("[]")
+            assert albedo.check(si.dimensionless)
 
     @staticmethod
     @pytest.mark.parametrize(
@@ -44,4 +44,4 @@ def test_optical_depth_unit(paper):
             )
 
             # assert
-            assert tau.check("[]")
+            assert tau.check(si.dimensionless)

tests/unit_tests/physics/test_particle_shape_and_density.py

@@ -57,4 +57,4 @@ def test_reynolds_number(variant):
             )
 
             # Assert
-            assert re.check("[]")
+            assert re.check(si.dimensionless)

tests/unit_tests/physics/test_trivia.py

@@ -71,7 +71,7 @@ def test_schmidt_number():
             )
 
             # Assert
-            assert sc.check("[]")
+            assert sc.check(si.dimensionless)
 
     @staticmethod
     def test_poissonian_avoidance_function():
@@ -82,10 +82,10 @@ def test_poissonian_avoidance_function():
             sut = formulae.trivia.poissonian_avoidance_function
 
             # Act
-            sc = sut(
+            prob = sut(
                 r=1 / si.s,
                 dt=10 * si.min,
             )
 
             # Assert
-            assert sc.check("[]")
+            assert prob.check(si.dimensionless)

tests/unit_tests/physics/test_ventilation_coefficient.py

@@ -25,7 +25,7 @@ def test_dimensionality(variant):
             re = sut(sqrt_re_times_cbrt_sc=1 * si.dimensionless)
 
             # Assert
-            assert re.check("[]")
+            assert re.check(si.dimensionless)
 
     @staticmethod
     @pytest.mark.parametrize(