From b87b738d0ec7bf87fd2ba1551822e70cfa9286f1 Mon Sep 17 00:00:00 2001 From: Takuya Iwanaga Date: Tue, 3 Jun 2025 17:44:10 +1000 Subject: [PATCH 1/2] Filled in criteria metadata TODO: Double check the percentile values for Hs and Tp (waves) --- src/utility/regions_criteria_setup.jl | 56 +++++++++++++-------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/src/utility/regions_criteria_setup.jl b/src/utility/regions_criteria_setup.jl index affa165..7789760 100644 --- a/src/utility/regions_criteria_setup.jl +++ b/src/utility/regions_criteria_setup.jl @@ -111,65 +111,65 @@ const ASSESSMENT_CRITERIA::Dict{String,CriteriaMetadata} = Dict( "Depth" => CriteriaMetadata(; id="Depth", file_suffix="_bathy", - display_label="Depth", - subtitle="TODO", - units="TODO", + display_label="Depth [m]", + subtitle="Depth from Mean Astronomical Tide", + units="meters", payload_prefix="depth_", default_bounds=Bounds(; min=-10, max=-2), - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Maximum depth", + max_tooltip="Minimum depth" ), "Slope" => CriteriaMetadata(; id="Slope", file_suffix="_slope", - display_label="Slope", - subtitle="TODO", - units="TODO", + display_label="Slope [degrees]", + subtitle="Slope of reef", + units="degrees", payload_prefix="slope_", - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Minimum slope angle (0 is flat)", + max_tooltip="Maximum slope angle" ), "Turbidity" => CriteriaMetadata(; id="Turbidity", file_suffix="_turbid", display_label="Turbidity", - subtitle="TODO", - units="TODO", + subtitle="Usual clarity of water", + units="Secchi depth meters", payload_prefix="turbidity_", - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Minimum Secchi depth", + max_tooltip="Maximum Secchi depth" ), "WavesHs" => CriteriaMetadata(; id="WavesHs", file_suffix="_waves_Hs", - display_label="Wave Height (m)", - subtitle="TODO", - units="TODO", + display_label="Wave Height [m]", + subtitle="Significant Wave Height (90th percentile)", + units="meters", payload_prefix="waves_height_", default_bounds=Bounds(; min=0, max=1), - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Minimum wave height", + max_tooltip="Maximum wave height" ), "WavesTp" => CriteriaMetadata(; id="WavesTp", file_suffix="_waves_Tp", - display_label="Wave Period (s)", - subtitle="TODO", - units="TODO", + display_label="Wave Period [s]", + subtitle="Time between waves in seconds (90th percentile)", + units="seconds", payload_prefix="waves_period_", default_bounds=Bounds(; min=0, max=6), - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Minimum periodicity", + max_tooltip="Maximum periodicity" ), "Rugosity" => CriteriaMetadata(; id="Rugosity", file_suffix="_rugosity", display_label="Rugosity", - subtitle="TODO", - units="TODO", + subtitle="Roughness of the sea floor", + units="stdev", payload_prefix="rugosity_", - min_tooltip="TODO", - max_tooltip="TODO" + min_tooltip="Minimum variability", + max_tooltip="Maximum variability" ) ) From 9bc18929f20c3872bd8e14a19516e753c647635a Mon Sep 17 00:00:00 2001 From: Takuya Iwanaga Date: Wed, 4 Jun 2025 09:51:35 +1000 Subject: [PATCH 2/2] Update src/utility/regions_criteria_setup.jl Swap tooltip text Co-authored-by: Peter Baker <87056634+PeterBaker0@users.noreply.github.com> --- src/utility/regions_criteria_setup.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utility/regions_criteria_setup.jl b/src/utility/regions_criteria_setup.jl index 7789760..b57eef1 100644 --- a/src/utility/regions_criteria_setup.jl +++ b/src/utility/regions_criteria_setup.jl @@ -116,8 +116,8 @@ const ASSESSMENT_CRITERIA::Dict{String,CriteriaMetadata} = Dict( units="meters", payload_prefix="depth_", default_bounds=Bounds(; min=-10, max=-2), - min_tooltip="Maximum depth", - max_tooltip="Minimum depth" + min_tooltip="Minimum depth", + max_tooltip="Maximum depth" ), "Slope" => CriteriaMetadata(; id="Slope",